Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty response when updating cluster settings #2907

Closed
lmenezes opened this issue Apr 17, 2013 · 3 comments
Closed

Empty response when updating cluster settings #2907

lmenezes opened this issue Apr 17, 2013 · 3 comments
Assignees
@s1monw
Labels
>enhancement v0.90.0

Comments

@lmenezes
Copy link
Contributor

This happens with at least 0.20.4 and 0.90.0.RC2, so I guess it happens on every version.
Is that the desired behaviour? It's just a bit confusing not getting any response and not being sure if the new value was really applied or not(or having to do another request and check if it was applied)

Eg:
curl -XPUT http://localhost:9200/_cluster/settings -d '{"transient":{"cluster.routing.allocation.disable_allocation":"true"}}'
@karmi
Copy link
Contributor

karmi commented Apr 17, 2013

//subscribe @karmi

@s1monw
Copy link
Contributor

s1monw commented Apr 17, 2013

this is the current behaviour but getting a response of the settings that we actually updated would be nice I agree. I think this should return the sub-set of settings that were accepted. Thoughts?

@lmenezes
Copy link
Contributor Author

sounds good to me.

@chilling chilling mentioned this issue Apr 17, 2013
Closed
chilling added a commit to chilling/elasticsearch that referenced this issue Apr 18, 2013
@chilling
# Response for Cluster Settings Update API
9dbcb7f 
If cluster settings are update the REST API returns the accepted values. For
example, updating the `cluster.routing.allocation.disable_allocation` via
cluster settings:

```curl -XPUT http://localhost:9200/_cluster/settings -d '{
    "transient":{
        "cluster.routing.allocation.disable_allocation":"true"
    }
}'```

will respond:

```{
    "persistent":{},
    "transient":{
        "cluster.routing.allocation.disable_allocation":"true"
    }
}```

Closes elastic#2907
@ghost ghost assigned s1monw Apr 18, 2013
@s1monw s1monw closed this as completed in 54cb4b9 Apr 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
>enhancement v0.90.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Response for Cluster Settings Update API chilling/elasticsearch
3 participants
@karmi @lmenezes @s1monw