The parameter is prefix_len not prefix_leng:

@clintongormley While I did have a typo in the term suggest, the phrase suggest example is working and demonstrates the issue. Could you reopen?

I will clarify that the gist was demonstrating that the term suggest is providing the term "iced" but I believe the candidate generator in the phrase suggest is not provided the term "iced" for the phrase suggest to consider because of the word length.

@jtreher sorry - got that completely wrong. I'll reopen

I'm seeing the same thing you're seeing.

@s1monw ?

this seems to be a bug in the min_doc_freq smoothing. The good thing is that this only happens if your query term has a freq = 1 and the replacement has a freq = 1 as well. So in practice this might not be an issue. I will have a fix soon, in the meanwhile this should help:

curl -XPOST 'localhost:9200/test/_suggest?pretty=true' -d '{                                                                                                                              
  "text": "ice tea",
  "did_you_mean": {
    "phrase": {
      "field": "name_shingled",
      "gram_size": 3,
      "direct_generator": [
        {
          "field": "name",
          "max_edits": 2,
          "suggest_mode": "always",
          "min_word_len": 0,
          "prefix_len": 0,
          "min_doc_freq": 1.0
        }
      ]
    }
  }
}'

@s1monw Is there any chance that max_term_freq is not being obeyed as well with "always?" While this patch fixed this test issue, I actually have a situation where ice appears thousands of times and iced several hundred. I see "iced" appear from the term suggest, but it's like the phrase suggest never gets it.

max_term_freq is the maximum threshold (default: 0.01f) of documents a query term can appear in order to provide suggestions. Which means that if you won't even get a candidate for ice if the freq exceeds max_term_freq. Maybe I am not understanding you question right?

@s1monw I have to set max_term_freq in the term suggest to 0.999 (99.9%) to have term show up. However, when I do this in phrase suggest, it's as though the candidate is not generated.

@s1monw This did fix the issue I had. It seems to respect max_term_freq now with 0.9.1

@jtreher I think I did!