New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install site plugin with custom url doesn't filter directory #3582
Comments
Right, the problem here is that we remove the top-level folder from the downloaded archive when we know we downloaded it from github, and we rely on a certain structure, which by the way sometimes changes (see #3551). If you manually provide a zip file we don't know where it came from and we don't remove the top-level folder, but only extract the zip file under the _site folder. Manually removing the top-level folder from the zip, or from the extracted directory would do the trick. |
Then another solution could be to add a download command to automate step 1:
This could be done on any workstation and produce the appropriate zip file. |
What would be the added value of automating the download without the install part, when we have the install command that does them both? For instance if you execute:
the elasticsearch-head will be downloaded from github, extracted properly and the plugin would be working without any manual work needed. Maybe I'm missing the reason why you are manually downloading the archive from github and installing it through the |
Because the ElasticSearch server can not access to internet (secured network zone). |
Ok I see what you mean, you would like to execute the Thanks for clarifying that! |
Having thought about this, I'd rather prefer to make the archive extraction smarter, so that it can detect that there is a top-level folder to remove, regardless of where the plugin came from. Looks like we can always do that whenever we have an archive that contains a single top-level folder. That would solve your issue without requiring to add the |
Whether we remove the top-level folder from the archive depends now on the zip itself and not on where it was downloaded from. That makes it work installing local files too. Closes elastic#3582
Whether we remove the top-level folder from the archive depends now on the zip itself and not on where it was downloaded from. That makes it work installing local files too. Closes #3582
Thanks for fixing that |
Thank you for reporting this! |
Whether we remove the top-level folder from the archive depends now on the zip itself and not on where it was downloaded from. That makes it work installing local files too. Closes elastic#3582
The folder could be stripped because it's same as file name.
The text was updated successfully, but these errors were encountered: