Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IndexShard#searcher() to IndexShard#acquireSearcher() #3653

Closed
s1monw opened this issue Sep 9, 2013 · 2 comments
Closed

Rename IndexShard#searcher() to IndexShard#acquireSearcher() #3653

s1monw opened this issue Sep 9, 2013 · 2 comments

Comments

@s1monw
Copy link
Contributor

s1monw commented Sep 9, 2013

to prevent issues like in #3652 we should make sure the name tells that it needs to be released

@ghost ghost assigned s1monw Sep 9, 2013
@jpountz
Copy link
Contributor

jpountz commented Sep 9, 2013

+1

@javanna
Copy link
Member

javanna commented Sep 9, 2013

Sounds good!

@s1monw s1monw closed this as completed in 5c00dc5 Sep 9, 2013
s1monw added a commit that referenced this issue Sep 9, 2013
Based on recent bugs ( #3652 ) where searchers were acquired multiple times
but never released 'IndexShard#searcher()' has not a more accurate name.

Closes #3653
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
Based on recent bugs ( elastic#3652 ) where searchers were acquired multiple times
but never released 'IndexShard#searcher()' has not a more accurate name.

Closes elastic#3653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants