Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate numeric_range filter, add a field data execution option to range filter #4034

Closed
kimchy opened this issue Oct 31, 2013 · 1 comment

Comments

@kimchy
Copy link
Member

kimchy commented Oct 31, 2013

numeric_range is very confusing, at the end, the question is if range filter should be done using the index itself, or using field data (in memory). I suggest deprecating numeric_range, and adding execution field to range filter, with possible values of index and fielddata. The numeric_range filter will be removed in the next major version after 1.0.

If its set to fielddata, we simply try and execute it using it (and if a mapper doesn't implement it, we simply fail the execution with unsupported exception).

@bleskes
Copy link
Contributor

bleskes commented Oct 31, 2013

+1

@ghost ghost assigned martijnvg Nov 25, 2013
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Nov 25, 2013
…data` as values.

Deprecated `numeric_range` filter in favor for the `range` filter with `fielddata` as execution.

Closes elastic#4034
martijnvg added a commit that referenced this issue Nov 25, 2013
…data` as values.

Deprecated `numeric_range` filter in favor for the `range` filter with `fielddata` as execution.

Closes #4034
dadoonet added a commit to dadoonet/elasticsearch that referenced this issue Aug 12, 2014
As done with elastic#4034, `numeric_range` filter has been deprecated since 1.0.0.

Closes elastic#7108.
dadoonet added a commit that referenced this issue Aug 13, 2014
As done with #4034, `numeric_range` filter has been deprecated since 1.0.0.

Closes #7108.
dadoonet added a commit that referenced this issue Sep 8, 2014
As done with #4034, `numeric_range` filter has been deprecated since 1.0.0.

Closes #7108.
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
…data` as values.

Deprecated `numeric_range` filter in favor for the `range` filter with `fielddata` as execution.

Closes elastic#4034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants