Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk should support shard timeout like the index api #4220

Closed
nik9000 opened this issue Nov 20, 2013 · 4 comments
Closed

Bulk should support shard timeout like the index api #4220

nik9000 opened this issue Nov 20, 2013 · 4 comments
Assignees
@kimchy
Labels
>enhancement v0.90.8 v1.0.0.Beta2

Comments

@nik9000
Copy link
Member

nik9000 commented Nov 20, 2013

It'd be nice if the bulk and delete api supported the shard timeout setting like the index api. This would allow updates to fail quickly if the shard is offline rather than waiting for the client side timeout and leaving the operation hanging around on the server.
@kimchy
Copy link
Member

kimchy commented Nov 20, 2013

  • delete does support setting the timeout, no?
  • bulk doesn't support setting the shard availability timeout, bit it does uses the default value (which is bounded).

@nik9000
Copy link
Member Author

nik9000 commented Nov 20, 2013

delete does support setting the timeout, no?

Looks like that is just a documentation problem then. http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/docs-delete.html doesn't have the word timeout on it.

bulk doesn't support setting the shard availability timeout, bit it does uses the default value (which is bounded).

It'd be useful if I could set it on a per request basis. Some of my requests I'd rather fail fast and others I'd rather let them wait. It isn't a big deal, the bulk commands that I need to fail fast I can convert into repeated update/index/delete calls and get a similar effect without too much overhead. They aren't huge bulk commands.

@kimchy
Copy link
Member

kimchy commented Nov 20, 2013

fixed the delete docs: a9880dc

@ghost ghost assigned kimchy Nov 21, 2013
@kimchy kimchy closed this as completed in 32d073b Nov 25, 2013
kimchy added a commit that referenced this issue Nov 25, 2013
@kimchy
Bulk should support shard timeout like the index api
6d22372 
closes #4220
@nik9000
Copy link
Member Author

nik9000 commented Nov 25, 2013

Thanks!

javanna pushed a commit to javanna/elasticsearch that referenced this issue Dec 27, 2013
@honzakral
[API] bulk request now supports timeout, see elastic#4220
2d29bb7
@nik9000 nik9000 mentioned this issue Jan 10, 2014
Closed
brusic pushed a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014
@honzakral @brusic
[API] bulk request now supports timeout, see elastic#4220
9297561
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@kimchy
Bulk should support shard timeout like the index api
5a107d1 
closes elastic#4220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kimchy kimchy

Labels
>enhancement v0.90.8 v1.0.0.Beta2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimchy @nik9000