New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shingle filter should expose filler_token
#4307
Comments
I agree that shingle filter needs to have some options here but as a workaround you can specify a |
OK thanks for the tip - that works for now. Presumably if position increment disabling has been removed from the Lucene core then the only workaround is to modify the shingle filter. I had a look at the Lucene source and it looks there is currently no method to override the filler token to an empty string which is currently hardcoded as an underscore. |
@MrHash yes that is correct. I think there needs to be one. I hope I will be able to open an issue and fix that in lucene soon. Feel free to beat me! |
here is an issue https://issues.apache.org/jira/browse/LUCENE-5353 |
Nice. I noticed also that the remove_trailing=false option of the stop filter also generates a filler token, despite enable_position_increments being set to false. Hopefully this update should also take care of this issue. |
with lucene 4.7 we will be able to make the filler token configurable. |
Lucene 4.7 supports a setter for the `filler_token` that is inserted if there are gaps in the token stream. This change exposes this setting. Closes #4307
Good stuff. |
Lucene 4.7 supports a setter for the `filler_token` that is inserted if there are gaps in the token stream. This change exposes this setting. Closes elastic#4307
Lucene 4.7 supports a setter for the `filler_token` that is inserted if there are gaps in the token stream. This change exposes this setting. Closes #4307
By using |
+1 |
@alup Could you open a new issue and provide more detail of the problem please? |
Ok, when I find some time, I will come up with an example to denote the problem. |
@apanimesh061 could you open a new issue for this, and include a full JSON recreation? |
Since Lucene 4.4 release enable_position_increment settings on token filters cannot be set to false which results in underscores appearing for filtered tokens in shingle filters.
The text was updated successfully, but these errors were encountered: