Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All field might loose configuration on serialization. #4579

Closed
s1monw opened this issue Jan 2, 2014 · 0 comments
Closed

All field might loose configuration on serialization. #4579

s1monw opened this issue Jan 2, 2014 · 0 comments

Comments

@s1monw
Copy link
Contributor

s1monw commented Jan 2, 2014

The all field tries to optimize for default cases and doesn't generate XContent if everything is default. The settings are not tested well enough and there is already differences between master and 0.90. Master is already missing to check autoboost and simiarity and 0.90 has misses settings if customFieldDataSettings is set as the only setting as well.

@ghost ghost assigned s1monw Jan 2, 2014
@s1monw s1monw closed this as completed in beaa915 Jan 2, 2014
s1monw added a commit that referenced this issue Jan 2, 2014
Today we try to detect if we need to generate the mapping or not in
the all mapper. This is error prone since it misses conditions if not
explicitly added. We should rather similate the generation instead.

This commit also adds a random test to check if the settings
of the all field mapper are correctly applied.

Closes #4579
Closes #4581
brusic pushed a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014
Today we try to detect if we need to generate the mapping or not in
the all mapper. This is error prone since it misses conditions if not
explicitly added. We should rather similate the generation instead.

This commit also adds a random test to check if the settings
of the all field mapper are correctly applied.

Closes elastic#4579
Closes elastic#4581
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
Today we try to detect if we need to generate the mapping or not in
the all mapper. This is error prone since it misses conditions if not
explicitly added. We should rather similate the generation instead.

This commit also adds a random test to check if the settings
of the all field mapper are correctly applied.

Closes elastic#4579
Closes elastic#4581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant