Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify RestRequest paramAsBoolean and paramAsBooleanOptional #4817

Closed
javanna opened this issue Jan 20, 2014 · 0 comments · Fixed by #4818
Closed

Unify RestRequest paramAsBoolean and paramAsBooleanOptional #4817

javanna opened this issue Jan 20, 2014 · 0 comments · Fixed by #4818
Assignees
@javanna
Labels
>enhancement v1.0.0

Comments

@javanna
Copy link
Member

javanna commented Jan 20, 2014

This is a follow-up of #4808: since paramAsBoolean and paramAsBooleanOptional do the same, with the only difference being their return type (boolean vs Boolean), their names should be the same. The fact that their names currently differ can be misleading.

The proposal is to rename paramAsBooleanOptional to paramAsBoolean. The original method will be kept around and deprecated though to keep backwards compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javanna javanna

Labels
>enhancement v1.0.0
Projects
None yet
Milestone
No milestone
1 participant
@javanna