Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terms aggregations: make size=0 return all terms #4837

Closed
jpountz opened this issue Jan 21, 2014 · 1 comment
Closed

Terms aggregations: make size=0 return all terms #4837

jpountz opened this issue Jan 21, 2014 · 1 comment
Assignees
@jpountz
Labels
>feature v1.1.0

Comments

@jpountz
Copy link
Contributor

jpountz commented Jan 21, 2014

This is a fork of #1776 for terms aggregations.

Setting size: 0 should make the number of terms returned by terms aggregations unlimited.
@ghost ghost assigned jpountz Jan 21, 2014
jpountz added a commit to jpountz/elasticsearch that referenced this issue Jan 21, 2014
@jpountz
Terms aggregations: make size=0 return all terms.
ab538f8 
Terms aggregations return up to `size` terms, so up to now, the way to get all
matching terms back was to set `size` to an arbitrary high number that would be
larger than the number of unique terms.

Terms aggregators already made sure to not allocate memory based on the `size`
parameter so this commit mostly consists in making `0` an alias for the
maximum integer value in the TermsParser.

Close elastic#4837
@jpountz jpountz mentioned this issue Jan 21, 2014
Closed
@uboness
Copy link
Contributor

uboness commented Jan 21, 2014

LGTM

jpountz added a commit that referenced this issue Jan 22, 2014
@jpountz
Terms aggregations: make size=0 return all terms.
8b0a863 
Terms aggregations return up to `size` terms, so up to now, the way to get all
matching terms back was to set `size` to an arbitrary high number that would be
larger than the number of unique terms.

Terms aggregators already made sure to not allocate memory based on the `size`
parameter so this commit mostly consists in making `0` an alias for the
maximum integer value in the TermsParser.

Close #4837
This was referenced Jan 22, 2014
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpountz jpountz

Labels
>feature v1.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Terms aggregations: make size=0 return all terms. jpountz/elasticsearch
2 participants
@uboness @jpountz