New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix potential NPE when no source and no body #4924
Labels
Comments
ghost
assigned dadoonet
Jan 28, 2014
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this issue
Jan 28, 2014
In recent changes, we added missing support for `source` parameter in some REST APIs: * elastic#4892 : mget * elastic#4900 : mpercolate * elastic#4901 : msearch * elastic#4902 : mtermvectors * elastic#4903 : percolate ```java BytesReference content = null; if (request.hasContent()) { content = request.content(); } else { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` It's definitely better to have: ```java BytesReference content = request.content(); if (!request.hasContent()) { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` That said, it could be nice to have a single method to manage it for various REST actions. Closes elastic#4924.
dadoonet
added a commit
that referenced
this issue
Jan 28, 2014
In recent changes, we added missing support for `source` parameter in some REST APIs: * #4892 : mget * #4900 : mpercolate * #4901 : msearch * #4902 : mtermvectors * #4903 : percolate ```java BytesReference content = null; if (request.hasContent()) { content = request.content(); } else { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` It's definitely better to have: ```java BytesReference content = request.content(); if (!request.hasContent()) { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` That said, it could be nice to have a single method to manage it for various REST actions. Closes #4924.
dadoonet
added a commit
that referenced
this issue
Jan 28, 2014
In recent changes, we added missing support for `source` parameter in some REST APIs: * #4892 : mget * #4900 : mpercolate * #4901 : msearch * #4902 : mtermvectors * #4903 : percolate ```java BytesReference content = null; if (request.hasContent()) { content = request.content(); } else { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` It's definitely better to have: ```java BytesReference content = request.content(); if (!request.hasContent()) { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` That said, it could be nice to have a single method to manage it for various REST actions. Closes #4924.
dadoonet
added a commit
that referenced
this issue
Jan 28, 2014
In recent changes, we added missing support for `source` parameter in some REST APIs: * #4892 : mget * #4900 : mpercolate * #4901 : msearch * #4902 : mtermvectors * #4903 : percolate ```java BytesReference content = null; if (request.hasContent()) { content = request.content(); } else { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` It's definitely better to have: ```java BytesReference content = request.content(); if (!request.hasContent()) { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` That said, it could be nice to have a single method to manage it for various REST actions. Closes #4924.
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
In recent changes, we added missing support for `source` parameter in some REST APIs: * elastic#4892 : mget * elastic#4900 : mpercolate * elastic#4901 : msearch * elastic#4902 : mtermvectors * elastic#4903 : percolate ```java BytesReference content = null; if (request.hasContent()) { content = request.content(); } else { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` It's definitely better to have: ```java BytesReference content = request.content(); if (!request.hasContent()) { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` That said, it could be nice to have a single method to manage it for various REST actions. Closes elastic#4924.
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
In recent changes, we added missing support for `source` parameter in some REST APIs: * elastic#4892 : mget * elastic#4900 : mpercolate * elastic#4901 : msearch * elastic#4902 : mtermvectors * elastic#4903 : percolate ```java BytesReference content = null; if (request.hasContent()) { content = request.content(); } else { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` It's definitely better to have: ```java BytesReference content = request.content(); if (!request.hasContent()) { String source = request.param("source"); if (source != null) { content = new BytesArray(source); } } ``` That said, it could be nice to have a single method to manage it for various REST actions. Closes elastic#4924.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In recent changes, we added missing support for
source
parameter in some REST APIs:It's definitely better to have:
That said, it could be nice to have a single method to manage it for various REST actions.
Where should we put it in?
The text was updated successfully, but these errors were encountered: