Refactor SimpleQueryParser settings into separate Settings class, add "lenient" option #5208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @Override | ||
| public Query newDefaultQuery(String text) { |
There was a problem hiding this comment.
can we factor the lentient handling part out in a single mehtod?
private Query rethrowUlessLentient(RuntimeException e) {
if (settings.lenient()) {
return null;
}
throw e;
}
man I with we had support for annonymous functions here or macros even :)
There was a problem hiding this comment.
Will do, yes, lambdas would be great, maybe in 5-7 years when we're finally on Java 8 minimum :)
|
LGTM |
|
Merged in 5429019 |
|
@dakrone Docs missing for this change |
|
@clintongormley pushed 99b0fae and a46cf50 to document this. |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5011