Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringBuilder should be used in place of StringBuffer #5605

Closed
pickypg opened this issue Mar 30, 2014 · 0 comments
Closed

StringBuilder should be used in place of StringBuffer #5605

pickypg opened this issue Mar 30, 2014 · 0 comments
Assignees
@javanna
Labels
>enhancement v1.2.0 v2.0.0-beta1

Comments

@pickypg
Copy link
Member

pickypg commented Mar 30, 2014

StringBuilder was made as an API compatible, drop-in replacement of StringBuffer without the generally unnecessary synchronization of every method.

Currently, StringBuffer is being used by PluginInfo#toString() (not vital, but still unnecessary) and FullRestartStressTest (less of an issue as it's test code).
pickypg added a commit to pickypg/elasticsearch that referenced this issue Mar 30, 2014
@pickypg
Replaces usage of StringBuffer with StringBuilder and fixes stray
9716db1 
single quote in the same `PluginInfo#toString()` method.

Closes elastic#5605
@pickypg pickypg mentioned this issue Mar 30, 2014
Closed
@javanna javanna closed this as completed in 70c089d Apr 1, 2014
javanna pushed a commit that referenced this issue Apr 1, 2014
@pickypg @javanna
Replaces usage of StringBuffer with StringBuilder and fixes stray
e2a7e10 
single quote in the same `PluginInfo#toString()` method.

Closes #5605
@javanna javanna self-assigned this Apr 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javanna javanna

Labels
>enhancement v1.2.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaces usage of StringBuffer with StringBuilder pickypg/elasticsearch
2 participants
@javanna @pickypg