Fix mapping creation on bulk request #5623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, wonderful catch! |
|
|
||
| @Test | ||
| public void testBulkIndexCreatesMapping() throws Exception { | ||
| cluster().wipe(); |
There was a problem hiding this comment.
this cluster().wipe() is unnecessary it happens during before / after already
When a bulk request triggers an index creation a mapping might not be created. The reason is that when indexing documents in a bulk, an indexing operation might fail due to a shard not yet being started. The mapping service, however, might already have the mapping but the mapping update is never issued to the master, even on subsequent indexing of documents. Instead, the mapping must be propagated to master even if the indexing fails due to a shard not being started.
|
Thanks for the comments! I updated the commits accordingly. I will push to master 1.x an 1.1. Should I also try and push to 1.0 and 0.90? |
| @@ -171,12 +173,27 @@ protected ShardIterator shards(ClusterState clusterState, BulkShardRequest reque | |||
| ops[requestIndex] = result.op; | |||
| } | |||
| } catch (Throwable e) { | |||
| if (e instanceof WriteFailure) { | |||
There was a problem hiding this comment.
Instead of doing the instanceof check here can we maybe wrap the body of the try / catch in another try catch and then rethrow? like this:
try {
try {
} catch (WriteFailure e) {
// do all the things
throw e.getCause(); // maybe check if e.getCause() can be null?
}
} catch (Throwable e) {
// do all the other things
}
|
change LGTM +1 to squash and push |
brwe
added a commit
that referenced
this pull request
Apr 2, 2014
When a bulk request triggers an index creation a mapping might not be created. The reason is that when indexing documents in a bulk, an indexing operation might fail due to a shard not yet being started. The mapping service, however, might already have the mapping but the mapping update is never issued to the master, even on subsequent indexing of documents. Instead, the mapping must be propagated to master even if the indexing fails due to a shard not being started. closes #5623
brwe
added a commit
that referenced
this pull request
Apr 2, 2014
When a bulk request triggers an index creation a mapping might not be created. The reason is that when indexing documents in a bulk, an indexing operation might fail due to a shard not yet being started. The mapping service, however, might already have the mapping but the mapping update is never issued to the master, even on subsequent indexing of documents. Instead, the mapping must be propagated to master even if the indexing fails due to a shard not being started. closes #5623
brwe
added a commit
that referenced
this pull request
Apr 2, 2014
When a bulk request triggers an index creation a mapping might not be created. The reason is that when indexing documents in a bulk, an indexing operation might fail due to a shard not yet being started. The mapping service, however, might already have the mapping but the mapping update is never issued to the master, even on subsequent indexing of documents. Instead, the mapping must be propagated to master even if the indexing fails due to a shard not being started. closes #5623
brwe
added a commit
to brwe/elasticsearch
that referenced
this pull request
Apr 10, 2014
If a document is percolated, the mapping service is updated while the document is parsed. The cluster state is not updated with the new mapping. If the same document is then indexed, the mapping is therfore not created. More explanaition in the test. This is similar to issue elastic#5623
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
When a bulk request triggers an index creation a mapping might not be created. The reason is that when indexing documents in a bulk, an indexing operation might fail due to a shard not yet being started. The mapping service, however, might already have the mapping but the mapping update is never issued to the master, even on subsequent indexing of documents. Instead, the mapping must be propagated to master even if the indexing fails due to a shard not being started. closes elastic#5623
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
When a bulk request triggers an index creation a mapping might not be created. The reason is that when indexing documents in a bulk, an indexing operation might fail due to a shard not yet being started. The mapping service, however, might already have the mapping but the mapping update is never issued to the master, even on subsequent indexing of documents. Instead, the mapping must be propagated to master even if the indexing fails due to a shard not being started. closes elastic#5623
lcawl
added
:Distributed/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bulk request triggers an index creation a mapping might not be
created. The reason is that when indexing documents in a bulk,
an indexing operation might fail due to a shard not yet being
started. The mapping service, however, might already
have the mapping but the mapping update is never issued to the master,
even on subsequent indexing of documents.
Instead, the mapping must be propagated to master even if the
indexing fails due to a shard not being started.