Fix Lucene's getFiniteStrings to not consume Java stack #5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…don't consume gobbs of Java stack; we'll remove this once we ugrade to Lucene 4.9
|
I agree with @spinscale we should have a static assert to remove this class once we upgrade |
|
Thanks @spinscale, that makes total sense, I'll do that! |
|
looks good |
clintongormley
added
>bug
:Search/Suggesters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request just copies in the fix for https://issues.apache.org/jira/browse/LUCENE-5628 to avoid problems like http://build.elasticsearch.com/job/es_jdk8_medium_master/34/jdk=JDK8,label=ubuntu-12-64-0-metal/testReport/junit/org.elasticsearch.search.suggest.completion/CompletionPostingsFormatTest/testDuellCompletions/ where a too-big string passed to the suggester can result in exhausting the Java stack.
Once LUCENE-5628 is fixed (I expect in 4.9), and we upgrade to it, we can remove this XSpecialOperations.