Function score multi values #5940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +36,7 @@ | |||
| import org.elasticsearch.index.fielddata.GeoPointValues; | |||
| import org.elasticsearch.index.fielddata.IndexGeoPointFieldData; | |||
| import org.elasticsearch.index.fielddata.IndexNumericFieldData; | |||
| import org.elasticsearch.index.fielddata.fieldcomparator.SortMode; | |||
There was a problem hiding this comment.
I think we should now move this mode into a util class maybe in org.elasticsearch.search.MultiValueMode
Decay functions currently only use the first value in a field that contains multiple values to compute the distance to the origin. Instead, it should consider all distances if more values are in the field and then use one of min/max/sum/avg which is defined by the user.
|
Thanks for the quick review! I updated the branch, added a commit for each comment. |
|
LGTM. |
|
LGTM |
s1monw
added a commit
that referenced
this pull request
Apr 28, 2014
Decay functions currently only use the first value in a field that contains multiple values to compute the distance to the origin. Instead, it should consider all distances if more values are in the field and then use one of min/max/sum/avg which is defined by the user. Relates to #3960 closes #5940
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decay functions currently only use the first value in a field that contains
multiple values to compute the distance to the origin. Instead, they should
consider all distances if more values are in the field and then use
one of min/max/sum/avg which is defined by the user.
closes #3960