Values of a multi-value fields are compared at the same level #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
|
|
||
| public final class XMoreLikeThis { | ||
|
|
There was a problem hiding this comment.
we usually do check the lucene version in a static block
static {
assert Version.CURRENT.luceneVersion == org.apache.lucene.utli.Version.LUCENE_48 : "Remove this class in Lucene 4.9";
}
|
LGTM except of the static assert that we should add |
…the same level. Previously, More Like This would create a new mlt query for each value of a multi-value field. This could result in all the values of the field to be selected, which defeats the purpose of More Like This. Instead, the correct behavior is to generate only one mlt query for all the values of the field. This commit provides the correct behavior for More Like This DSL. The fix for More Like This API will be coming in another commit.
alexksikes
added a commit
that referenced
this pull request
Jun 3, 2014
…the same level. Previously, More Like This would create a new mlt query for each value of a multi-value field. This could result in all the values of the field to be selected, which defeats the purpose of More Like This. Instead, the correct behavior is to generate only one mlt query for all the values of the field. This commit provides the correct behavior for More Like This DSL. The fix for More Like This API will be coming in another commit. Closes #6310
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, More Like This would create a new mlt query for each value of a
multi-value field. This could result in all the values of the field to be
selected, which defeats the purpose of More Like This. Instead, the correct
behavior is to generate only one mlt query for all the values of the field.
This commit provides the correct behavior for More Like This DSL. The fix for
More Like This API will be coming in another commit.