Allow _version to use disk as a doc values format.
#6523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VersionFieldMapper.defaultDocValuesFormat claims that the default is `disk`. This is not used to choose the DV format in the index but for mappings serialization in order to know when the _version doc values format is different from the default format. This made it impossible to use the `disk` doc values format since mappings would never retain that information at serialization time.
|
LGTM |
|
LGTM should also go into |
jpountz
added a commit
that referenced
this pull request
Jun 19, 2014
VersionFieldMapper.defaultDocValuesFormat claims that the default is `disk`. This is not used to choose the DV format in the index but for mappings serialization in order to know when the _version doc values format is different from the default format. This made it impossible to use the `disk` doc values format since mappings would never retain that information at serialization time. Close #6523
jpountz
added a commit
that referenced
this pull request
Jun 19, 2014
VersionFieldMapper.defaultDocValuesFormat claims that the default is `disk`. This is not used to choose the DV format in the index but for mappings serialization in order to know when the _version doc values format is different from the default format. This made it impossible to use the `disk` doc values format since mappings would never retain that information at serialization time. Close #6523
clintongormley
added
the
:Search/Mapping
clintongormley
changed the title
disk as a doc values format.disk as a doc values format.
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
VersionFieldMapper.defaultDocValuesFormat claims that the default is `disk`. This is not used to choose the DV format in the index but for mappings serialization in order to know when the _version doc values format is different from the default format. This made it impossible to use the `disk` doc values format since mappings would never retain that information at serialization time. Close elastic#6523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VersionFieldMapper.defaultDocValuesFormat claims that the default is
disk(which is wrong, it's using Lucene's defaults).
This is not used to choose the DV format in the index but for mappings
serialization in order to know when the _version doc values format is
different from the default format. This made it impossible to use the
diskdoc values format since mappings would never retain that information at
serialization time.