Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON response for significant terms #6535

Closed
wants to merge 3 commits into from

Conversation

brwe
Copy link
Contributor

@brwe brwe commented Jun 17, 2014

Commit fbd7c9a introduced a regression that caused
the min_doc_count to be equal to the number of documents in the
background set. As a result no buckets were built when the
response for significant terms was created.
This only affected the final XContent response.

Commit fbd7c9a introduced a regression that caused
the min_doc_count to be equal to the number of documents in the
background set. As a result no buckets were built when the
response for significant terms was created.
This only affected the final XContent response.
@jpountz
Copy link
Contributor

jpountz commented Jun 17, 2014

Good catch! +1

brwe added a commit that referenced this pull request Jun 18, 2014
Commit fbd7c9a introduced a regression that caused
the min_doc_count to be equal to the number of documents in the
background set. As a result no buckets were built when the
response for significant terms was created.
This only affected the final XContent response.

closes #6535
brwe added a commit that referenced this pull request Jun 18, 2014
Commit fbd7c9a introduced a regression that caused
the min_doc_count to be equal to the number of documents in the
background set. As a result no buckets were built when the
response for significant terms was created.
This only affected the final XContent response.

closes #6535
@brwe brwe closed this in 1cbeaf6 Jun 18, 2014
@s1monw s1monw removed the review label Jun 18, 2014
@clintongormley clintongormley changed the title significant terms: fix json response Aggs: [significant terms] fix json response Jul 9, 2014
@clintongormley clintongormley changed the title Aggs: [significant terms] fix json response Aggregations: fix json response for significant terms Jul 9, 2014
@clintongormley clintongormley changed the title Aggregations: fix json response for significant terms Aggregations: fix JSON response for significant terms Jul 9, 2014
@clintongormley clintongormley changed the title Aggregations: fix JSON response for significant terms Aggregations: Fix JSON response for significant terms Jul 16, 2014
@clintongormley clintongormley changed the title Aggregations: Fix JSON response for significant terms Fix JSON response for significant terms Jun 7, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Commit fbd7c9a introduced a regression that caused
the min_doc_count to be equal to the number of documents in the
background set. As a result no buckets were built when the
response for significant terms was created.
This only affected the final XContent response.

closes elastic#6535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants