Test: Randomize netty worker and connection parameters #6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try and push our system to a state where there is only a single worker, trying to expose potential deadlocks when we by mistake execute blocking operations on the worker thread closes elastic#6635
|
LGTM FWIW 😋 |
|
|
||
| // randomize netty settings | ||
| if (random.nextBoolean()) { | ||
| builder.put(NettyTransport.WORKER_COUNT, random.nextInt(3) + 1); |
There was a problem hiding this comment.
can we go higher here? I mean if folks can set this they might go and use a large number? If that is dangerous we might need to validate the input and throw an exception?
There was a problem hiding this comment.
we could, the default is num_processors * 2, which happens when nextBoolean is false. I wanted to try and be more aggressive when it is enabled. I think this values are good.
regarding the default, I am not sure what a good protection here is. We could protect from someone setting it to 500, or 10 times the number of processors, but I don't think it will be that effective (besides the fact that its a pretty internal and advance setting).
|
LGTM |
kimchy
added a commit
that referenced
this pull request
Jun 30, 2014
Try and push our system to a state where there is only a single worker, trying to expose potential deadlocks when we by mistake execute blocking operations on the worker thread closes #6635
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try and push our system to a state where there is only a single worker, trying to expose potential deadlocks when we by mistake execute blocking operations on the worker thread