Do not ignore ConnectTransportException for shard replication operations #6813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.info("--> primary shard is on {}", primaryNode); | ||
|
|
||
| // Index a document to make sure everything works well | ||
| internalCluster().client(primaryNode).prepareIndex(INDEX, "doc").setSource("foo", "bar").get(); |
There was a problem hiding this comment.
maybe verify that this doc is indexed on both shard copies?
There was a problem hiding this comment.
@martijnvg I'm trying to think of the best way to verify where the document exists on both shards, I guess just get the document count from the stats for each shard? Checking that the indexing op doesn't fail is kind of redundant for this, so it could be entirely removed.
|
LGTM, left two minor comments |
|
|
||
| package org.elasticsearch.index; | ||
|
|
||
| import com.carrotsearch.ant.tasks.junit4.dependencies.com.google.common.collect.ImmutableSet; |
There was a problem hiding this comment.
can we import from our version Guava? I think we should add all of this to forbidden APIs at another pull request
|
LGTM |
A ConnectTransportException should fail the replica shard Closes elastic#6183
clintongormley
changed the title
clintongormley
changed the title
lcawl
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ConnectTransportException on replicating an index operation should fail the replica shard.
This case came out of the
improve_zenbranch for index requests that are mid-flight while partitioning is forced.