Make XContentBuilder Releasable #6869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the builder releasable (auto closeable), and use it in shards state also make XContentParser releasable (AutoCloseable) and not closeable since it doesn't throw an IOException closes elastic#6869
|
LGTM |
kimchy
added a commit
that referenced
this pull request
Jul 15, 2014
make the builder releasable (auto closeable), and use it in shards state also make XContentParser releasable (AutoCloseable) and not closeable since it doesn't throw an IOException closes #6869
kimchy
added a commit
that referenced
this pull request
Jul 15, 2014
make the builder releasable (auto closeable), and use it in shards state also make XContentParser releasable (AutoCloseable) and not closeable since it doesn't throw an IOException closes #6869
clintongormley
changed the title
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
make the builder releasable (auto closeable), and use it in shards state also make XContentParser releasable (AutoCloseable) and not closeable since it doesn't throw an IOException closes elastic#6869
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the builder releasable (auto closeable), and use it in shards state
also make XContentParser releasable (AutoCloseable) and not closeable since it doesn't throw an IOException