@@ -7,6 +7,7 @@ * Bugfixes * XML fragments with namespaces do not raise an exception (regression in 1.4.0) + * Node#matches? works in nodes contained by a DocumentFragment. GH #158 === 1.4.0 / 2009/10/30 CHANGELOG.rdoc @@ -279,7 +279,7 @@ module Nokogiri ### # Returns true if this Node matches +selector+ def matches? selector - document.search(selector).include?(self) + ancestors.last.search(selector).include?(self) end #### @@ -435,8 +435,10 @@ module Nokogiri return NodeSet.new(document, parents) unless selector + root = parents.last + NodeSet.new(document, parents.find_all { |parent| - parent.matches?(selector) + root.search(selector).include?(parent) }) end lib/nokogiri/xml/node.rb @@ -9,6 +9,19 @@ module Nokogiri @html = Nokogiri::HTML.parse(File.read(HTML_FILE), HTML_FILE) end + def test_ancestors_search + html = %q{ + <div> + <ul> + <li>foo</li> + </ul> + </div> + } + fragment = Nokogiri::HTML.fragment html + li = fragment.at('li') + assert li.matches?('li') + end + def test_fun_encoding string = %Q(<body>こんにちは</body>) html = Nokogiri::HTML::DocumentFragment.parse( test/html/test_document_fragment.rb @@ -78,6 +78,14 @@ module Nokogiri assert_equal 'div', list.first.name end + def test_matches_inside_fragment + fragment = DocumentFragment.new @html + fragment << XML::Node.new('a', @html) + + a = fragment.children.last + assert a.matches?('a'), 'a should match' + end + def test_css_matches? assert node = @html.at('a.bar') assert node.matches?('a.bar') test/html/test_node.rb 108b5d24231bda324157b215f1284a3e9593aeeb Aaron Patterson aaron.patterson@gmail.com http://github.com/entangledstate/nokogiri/commit/d41db1a1d949ab7827b54e2789b5ee1addf2c45b d41db1a1d949ab7827b54e2789b5ee1addf2c45b

2009-11-05T14:34:14-08:00

Node#matches? works in nodes contained by a DocumentFragment. closes #158 787229612c0dd9c7f812f1c4e43c0c1155f9ee7a Aaron Patterson aaron.patterson@gmail.com