Add IS_STATIC opcode #2975
Merged
Add IS_STATIC opcode #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `IS_STATIC (0x4A)` opcode that pushes `1` if the current context is static (ie. the execution is in a `STATICCALL` or a descendant thereof, so state-changing operations are not possible), and `0` if it is not.
MicahZoltu
approved these changes
Sep 13, 2020
Comment on lines
+12
to
+16
| ## Simple Summary | ||
|
|
||
| Add a `IS_STATIC (0x4A)` opcode that pushes `1` if the current context is static (ie. the execution is in a `STATICCALL` or a descendant thereof, so state-changing operations are not possible), and `0` if it is not. | ||
|
|
||
| ## Abstract |
There was a problem hiding this comment.
Suggested change
| ## Simple Summary | |
| Add a `IS_STATIC (0x4A)` opcode that pushes `1` if the current context is static (ie. the execution is in a `STATICCALL` or a descendant thereof, so state-changing operations are not possible), and `0` if it is not. | |
| ## Abstract | |
| ## Simple Summary | |
| Adds an opcode to detect if the current call context is limited to read-only operations. | |
| ## Abstract | |
| Add a `IS_STATIC (0x4A)` opcode that pushes `1` if the current context is static (ie. the execution is in a `STATICCALL` or a descendant thereof, so state-changing operations are not possible), and `0` if it is not. |
The current simple summary feels more like an abstract due to the level of detail it goes into and how it basically mirrors the specification.
There was a problem hiding this comment.
It simply does not make sense to have both.
There was a problem hiding this comment.
The purpose of the simple summary is to give a one sentence overview of what this EIP is. You can imagine it showing up in some places as a sub-title or inline description. Think "email subject line". Abstract's purpose is to describe the specification in human readable terms, with perhaps some of the minor details and edge cases left out.
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
Add a `IS_STATIC (0x4A)` opcode that pushes `1` if the current context is static (ie. the execution is in a `STATICCALL` or a descendant thereof, so state-changing operations are not possible), and `0` if it is not.
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
Add a `IS_STATIC (0x4A)` opcode that pushes `1` if the current context is static (ie. the execution is in a `STATICCALL` or a descendant thereof, so state-changing operations are not possible), and `0` if it is not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
IS_STATIC (0x4A)opcode that pushes1if the current context is static (ie. the execution is in aSTATICCALLor a descendant thereof, so state-changing operations are not possible), and0if it is not.