Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllExpectations should fail the test for unimplemented error #298

Closed
kretes opened this issue Sep 25, 2014 · 1 comment
Closed

AllExpectations should fail the test for unimplemented error #298

kretes opened this issue Sep 25, 2014 · 1 comment

Comments

@kretes
Copy link

kretes commented Sep 25, 2014

Having a test case like this:

import org.specs2.mutable.Specification
import org.specs2.specification.AllExpectations

class AllExpectationsSpec extends Specification with AllExpectations {

  def sut:String = ???

  "all expectations spec" should {
    "fail when exception happens" in {
      sut must beEqualTo("a")
    }
  }

}

The result is green, although it obviously fails.

Removing AllExpectations makes the test be 'red' as expected

Checked with specs2 2.4.4

@etorreborre
Copy link
Owner

I fixed this issue. You can try the fix in 2.5-SNAPSHOT.

etorreborre added a commit that referenced this issue Oct 1, 2014
Conflicts:
	common/src/main/scala/org/specs2/execute/ResultExecution.scala
	core/src/main/scala/org/specs2/specification/ResultsContext.scala
	core/src/main/scala/org/specs2/specification/process/Stats.scala
	core/src/test/scala/org/specs2/specification/AllExpectationsSpec.scala
	junit/src/main/scala/org/specs2/matcher/JUnitExpectations.scala
	junit/src/main/scala/org/specs2/reporter/JUnitReporter.scala
	matcher/src/main/scala/org/specs2/matcher/MatchResult.scala
	matcher/src/main/scala/org/specs2/matcher/Matcher.scala
	matcher/src/main/scala/org/specs2/matcher/StandardMatchResults.scala
etorreborre added a commit that referenced this issue Oct 1, 2014
Conflicts:
	common/src/main/scala/org/specs2/execute/ResultExecution.scala
	core/src/main/scala/org/specs2/specification/ResultsContext.scala
	core/src/main/scala/org/specs2/specification/process/Stats.scala
	core/src/test/scala/org/specs2/specification/AllExpectationsSpec.scala
	junit/src/main/scala/org/specs2/matcher/JUnitExpectations.scala
	junit/src/main/scala/org/specs2/reporter/JUnitReporter.scala
	matcher/src/main/scala/org/specs2/matcher/MatchResult.scala
	matcher/src/main/scala/org/specs2/matcher/Matcher.scala
	matcher/src/main/scala/org/specs2/matcher/StandardMatchResults.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants