evanphx / rubinius fork watch download tarball
public
Description: Rubinius, the Ruby VM
Homepage: http://rubini.us
Clone URL: git://github.com/evanphx/rubinius.git
Search Repo: 
Revert "Made DRb spec depend partially on PID so multiple runs don't 
clash."

The spec is designed for sane behavior, if Rubinius or the
implementation of DRb is causing problems then they should be
fixed, not the spec in this case.  Fixing the spec will only
hide the bug.

See http://jira.codehaus.org/browse/JRUBY-2347 for more commentary on the 
problem.

This reverts commit f89bd8c6c425c9d9bcc3e589b8d3b05ce3ccbced.
dgtized (author)
Sun Apr 27 12:51:16 -0700 2008
commit  08695d9a6940ab74f6eb8965e449a417002a42a6
tree    24c9d0af4e93fd7cdd1b957e3b52c157eaa61659
parent  94ba0884c8e7f398b6fe8d6736834f62f6a49815
0
spec/ruby/1.8/library/drb/start_service_spec.rb 
...
3
4
5
6
7
8
9
10
11
12
13
 
14
15
 
16
17
18
19
...
20
21
22
23
 
24
25
 
26
27
28
 
...
3
4
5
 
 
 
 
 
6
7
 
8
9
 
10
11
12
13
14
...
15
16
17
 
18
19
 
20
21
22
23
 
0
@@ -3,16 +3,11 @@
0
 require 'drb'
0
 
0
 describe "DRb.start_service" do
0
-  before :all do
0
-    port = 9001 + (Process.pid & 7)
0
-    @url = "druby://localhost:#{port}"
0
-  end
0
-
0
   it "should run a basic remote call" do    
0
     lambda { DRb.current_server }.should raise_error(DRb::DRbServerNotFound)
0
-    server = DRb.start_service(@url, TestServer.new)
0
+    server = DRb.start_service('druby://localhost:9001', TestServer.new)
0
     DRb.current_server.should == server
0
-    obj = DRbObject.new(nil, @url)
0
+    obj = DRbObject.new(nil, 'druby://localhost:9001')
0
     obj.add(1,2,3).should == 6
0
     DRb.stop_service
0
     lambda { DRb.current_server }.should raise_error(DRb::DRbServerNotFound)
0
0
@@ -20,9 +15,9 @@
0
 
0
   it "should run a basic remote call passing a block" do
0
     lambda { DRb.current_server }.should raise_error(DRb::DRbServerNotFound)
0
-    server = DRb.start_service(@url, TestServer.new)
0
+    server = DRb.start_service('druby://localhost:9001', TestServer.new)
0
     DRb.current_server.should == server
0
-    obj = DRbObject.new(nil, @url)
0
+    obj = DRbObject.new(nil, 'druby://localhost:9001')
0
     obj.add_yield(2) do |i|
0
       i.should == 2
0
       i+1

Comments

    No one has commented yet.