Comments

ezecosystem · May 22, 2017 · ad8835c · ad8835c
1 parent f8eb2a2
commit ad8835c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Core/WorkflowServiceFacade.php b/Core/WorkflowServiceFacade.php
@@ -25,10 +25,11 @@ public function __construct(MigrationService $innerService, $cacheDir, $debugMod
     }
 
     /**
-     * Unlike its parent's similar function, this one only deals with *parsed* definitions
+     * Unlike its parent's similar function, this one only deals with *parsed* definitions.
+     * NB: this function, unlike getValidWorkflowsDefinitionsForSignal, does not cache its results, which might lead to
+     * some hard-to troubleshoot weirdness...
      * @param string[] $paths
      * @return MigrationDefinitionCollection
-     * @todo add caching as this is quite inefficient
      */
     public function getWorkflowsDefinitions($paths = array())
     {
@@ -50,7 +51,6 @@ public function getWorkflowsDefinitions($paths = array())
      * @param $signalName
      * @param string[] $paths
      * @return MigrationDefinitionCollection
-     * @todo add caching as this is quite inefficient
      */
     public function getValidWorkflowsDefinitionsForSignal($signalName, $paths = array())
     {