Rename setcookie route to set_session_cookie

Rename the route to set_session_cookie to convey that this endpoint isn't used for tracking or serving ads. Otherwise the path "/setcookie?" will get blocked by ad blockers like uBlock Origin and wipr.
ezpublishlegacy · Jan 24, 2019 · ab920af · ab920af
1 parent f002baf
commit ab920af
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/Controller/ApiController.php b/Controller/ApiController.php
@@ -31,7 +31,7 @@ public function setAuthenticationAction(Request $request)
     /**
      * Set cookie from API server to my server
      * 
-     * @Route("/setcookie")
+     * @Route("/set_session_cookie")
      * @Method({"GET", "POST"})
      * 
      * @param Request $request
@@ -152,4 +152,4 @@ public function deleteSessionAction(Request $request, $sessionId)
     {
         return $this->get('xrow_rest.api.helper')->deleteSession($request, $sessionId);
     }
-}
+}
diff --git a/Controller/ApiControllerV2.php b/Controller/ApiControllerV2.php
@@ -34,7 +34,7 @@ public function setOpenIDConnectAuthenticationAction(Request $request)
     /**
      * Set cookie from API server to my server
      * 
-     * @Route("/setcookie")
+     * @Route("/set_session_cookie")
      * @Method({"GET", "POST"})
      * 
      * @param Request $request
@@ -291,4 +291,4 @@ public function setLocalstorageTokenAction(Request $request)
         }
         return new JsonResponse();
     }
-}
+}
diff --git a/Resources/views/angular/openIDConnect/login.html.twig b/Resources/views/angular/openIDConnect/login.html.twig
@@ -21,7 +21,7 @@
                              "openIDConnectURL": "{{oa_params.endpoint_rest}}/oicauth",
                              "apiSessionURL": "{{oa_params.endpoint_rest}}/session",
                              "apiLogoutURL": "{{oa_params.endpoint_rest}}/sessions",
-                             "setcookieURL": "{{oa_params.endpoint_rest}}/setcookie",
+                             "setcookieURL": "{{oa_params.endpoint_rest}}/set_session_cookie",
                              "checkSessionIframeURL": "{{oa_params.endpoint_rest}}/check_session_iframe"};
         </script>
 
@@ -46,4 +46,4 @@
                 .then(null, console.error.bind(console));
         </script>
     </body>
-</html>
+</html>
diff --git a/Resources/views/page_head_script.html.twig b/Resources/views/page_head_script.html.twig
@@ -13,7 +13,7 @@ var lsKeyName = 'xrowOpenIDConnect',
                      "openIDConnectURL": "{{oa_params.endpoint_rest}}/oicauth",
                      "apiSessionURL": "{{oa_params.endpoint_rest}}/session",
                      "apiLogoutURL": "{{oa_params.endpoint_rest}}/sessions",
-                     "setcookieURL": "{{oa_params.endpoint_rest}}/setcookie",
+                     "setcookieURL": "{{oa_params.endpoint_rest}}/set_session_cookie",
                      "checkSessionIframeURL": "{{oa_params.endpoint_rest}}/check_session_iframe"};
 
 if (typeof pathToLoginTemplate === 'undefined') {
@@ -65,4 +65,4 @@ var callbackRestLoginFormErrorHandling = '{{oa_params.callback_function_if_restL
     });
 </script>
 {% endif %}
-{# ANGULAR 2 End #}
+{# ANGULAR 2 End #}