@@ -1,5 +1,5 @@ -v0.1. Nil out the array after each pass. +v0.1. Nil out the array after each pass; don't freeze the array anymore. v0.0.2. Avoid a couple more dispatches. CHANGELOG @@ -13,9 +13,10 @@ static VALUE foreach(VALUE self, VALUE filename) { char *token; int idx; - VALUE ary = rb_ary_new(); + VALUE ary; while (fgets(line, sizeof(line), file) != NULL) { + ary = rb_ary_new(); token = strtok(line, DELIMITERS); idx = 0; @@ -25,13 +26,13 @@ static VALUE foreach(VALUE self, VALUE filename) { token = strtok(NULL, DELIMITERS); } - OBJ_FREEZE(ary); + /* OBJ_FREEZE(ary); */ rb_yield(ary); - FL_UNSET((ary), FL_FREEZE); + /* FL_UNSET((ary), FL_FREEZE); */ - for(idx = 0; idx < RARRAY_LEN(ary); idx ++) { + /* for(idx = 0; idx < RARRAY_LEN(ary); idx ++) { rb_ary_store(ary, idx, Qnil); - } + } */ } ext/ccsv.c @@ -3,5 +3,5 @@ #include "node.h" #define DELIMITERS ",\n" -#define MAX_LENGTH 8096 +#define MAX_LENGTH 2048 #define ARY_DEFAULT_SIZE 16 ext/ccsv.h c4b5d3f4a518fd96acf298c048b312fffd0f813d Evan Weaver evan@cloudbur.st http://github.com/fauna/ccsv/commit/78584f6c500e38fe8cd374c331feeff32fbb45b2 78584f6c500e38fe8cd374c331feeff32fbb45b2 2008-01-05T15:20:01-08:00 2008-01-05T15:20:01-08:00 better to use a new array 61a21c8212bc45c0f9bc041314183c9f58a040f5 Evan Weaver evan@cloudbur.st