@@ -23,15 +23,17 @@ class ActiveRecord::Base #:nodoc: def _remove_tags outgoing taggable?(true) outgoing = tag_cast_to_string(outgoing) + return [] if outgoing.empty? <% if options[:self_referential] %> # because of http://dev.rubyonrails.org/ticket/6466 taggings.destroy(*(taggings.find(:all, :include => :<%= parent_association_name -%>).select do |tagging| outgoing.include? tagging.<%= parent_association_name -%>.name end)) - <% else -%> - <%= parent_association_name -%>s.delete(*(<%= parent_association_name -%>s.select do |tag| - outgoing.include? tag.name - end)) + <% else -%> + outgoing_tags = <%= parent_association_name -%>s.find_all_by_name(outgoing) + outgoing_taggings = taggings.find_all_by_<%= parent_association_name -%>_id(outgoing_tags.map(&:id)) + + taggings.destroy(*outgoing_taggings) <% end -%> end generators/tagging/templates/tagging_extensions.rb 104665587138345bb0ef799065d175f3513ea166 Paulo Pereira paulo.zoom@gmail.com http://github.com/fauna/has_many_polymorphs/commit/01db462d35814c42f5ae76309e9eb583becae919 01db462d35814c42f5ae76309e9eb583becae919 2009-04-27T16:58:29-07:00 2009-04-16T09:49:56-07:00 Changed _remove_tags so that it calls Tagging#destroy instead. This way Tagging#after_destroy is properly triggered and orphaned tags are destroyed. Signed-off-by: Snax Fauna <evan+fauna@cloudbur.st> 2859c7fc8a4805e3cfa08364e1fc48d99bf7dd41 Snax Fauna evan+fauna@cloudbur.st