1faf20cf809614fd09d01b1b23fdf90eaaa9f9af Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/f201bbd07e320d340f4fc95aa60d44e45b339074 f201bbd07e320d340f4fc95aa60d44e45b339074 2009-06-15T16:23:23-07:00 2009-06-15T15:42:41-07:00 Bump version to 0.0.19 Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> 8722f6515a80ac5fc410035fe504da12af5ce742 Felipe Contreras felipe.contreras@gmail.com 2d920b23e076afe3b6eac56b6adb43c8e72103d8 Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/1faf20cf809614fd09d01b1b23fdf90eaaa9f9af 1faf20cf809614fd09d01b1b23fdf90eaaa9f9af 2009-06-15T16:23:23-07:00 2009-06-15T16:16:57-07:00 po: general translation updates 0b4ddd92e213b2c26e6f1cd6c16ca3ef1e8dbd8f Felipe Contreras felipe.contreras@gmail.com f59ef0e1ae610975bf05149de3e0837b0fc5452a Wei Hsiang Hung weihsiang.hung@gmail.com http://github.com/felipec/msn-pecan/commit/2d920b23e076afe3b6eac56b6adb43c8e72103d8 2d920b23e076afe3b6eac56b6adb43c8e72103d8 2009-06-15T16:23:23-07:00 2009-06-15T16:14:17-07:00 po: update Traditional Chinese translation 4285308b61726c8c0810f1cf4bf0a1e50f161527 Felipe Contreras felipe.contreras@gmail.com 77dd91b534bd98f390116260b9a317bbcf957e9f Albert Cervin albert@cavalince.com http://github.com/felipec/msn-pecan/commit/f59ef0e1ae610975bf05149de3e0837b0fc5452a f59ef0e1ae610975bf05149de3e0837b0fc5452a 2009-06-15T16:23:23-07:00 2009-06-15T16:11:24-07:00 po: update Swedish translation 6be63797cf2447bc50aa79df349db0e045428547 Felipe Contreras felipe.contreras@gmail.com 60ae2f85a8f409cd58aca06c5e407e1ad552bd6e Luís Neto luisneto3@clix.pt http://github.com/felipec/msn-pecan/commit/77dd91b534bd98f390116260b9a317bbcf957e9f 77dd91b534bd98f390116260b9a317bbcf957e9f 2009-06-15T16:23:22-07:00 2009-06-15T16:09:07-07:00 po: update Portuguese translation 1a05c869d269b50f69cb6b6dc10b63b5f0091a6e Felipe Contreras felipe.contreras@gmail.com aa5ca5198dc832a348decc4b0d6aa8dec370fbdc Devid Antonio Filoni devidfil@gmail.com http://github.com/felipec/msn-pecan/commit/60ae2f85a8f409cd58aca06c5e407e1ad552bd6e 60ae2f85a8f409cd58aca06c5e407e1ad552bd6e 2009-06-15T16:23:22-07:00 2009-06-15T16:06:00-07:00 po: update Italian translation bc10cda14eba5df06f5cd4b4d2f2c2ba3faae020 Felipe Contreras felipe.contreras@gmail.com ffc6a5b0e7a6e78809d23062bb626e8e82c0c569 Elias Julkunen elias.julkunen@gmail.com http://github.com/felipec/msn-pecan/commit/aa5ca5198dc832a348decc4b0d6aa8dec370fbdc aa5ca5198dc832a348decc4b0d6aa8dec370fbdc 2009-06-15T16:23:22-07:00 2009-06-15T15:58:21-07:00 po: update Finnish translation 9e1176baa0ae42d5c8f1a473c29a7e6313bf5368 Felipe Contreras felipe.contreras@gmail.com cadb67195b4782eed98c804a23eb8cf92548bd2f Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/ffc6a5b0e7a6e78809d23062bb626e8e82c0c569 ffc6a5b0e7a6e78809d23062bb626e8e82c0c569 2009-06-15T13:07:45-07:00 2009-06-15T13:07:45-07:00 Fix SLP DATA message creation Some platforms (OSX) had a problem with that. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> df3ebb42f64cf53ba3fa7a71cfa11bb0ab9a6f55 Felipe Contreras felipe.contreras@gmail.com a0add98cff6366c9803df36d50d8c463818b31d3 Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/cadb67195b4782eed98c804a23eb8cf92548bd2f cadb67195b4782eed98c804a23eb8cf92548bd2f 2009-06-15T13:04:59-07:00 2009-06-15T13:04:59-07:00 Optimize GType retrieval Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> 27acc5b9602a96397aa1bf5b2aafd74945e274eb Felipe Contreras felipe.contreras@gmail.com 901e09e50d8c9aa43ee92f654afaf17c32628479 Devid Antonio Filoni devidfil@gmail.com http://github.com/felipec/msn-pecan/commit/a0add98cff6366c9803df36d50d8c463818b31d3 a0add98cff6366c9803df36d50d8c463818b31d3 2009-06-15T13:04:36-07:00 2009-06-15T13:03:53-07:00 slp: destroy object at the right time Otherwise wrong memory could be accessed. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> f1080d136bbc9c10cc90da9ed3370025c533fd92 Felipe Contreras felipe.contreras@gmail.com b1a4a7c6c92d05a485e4d6438d6c23ebbbe9a60d Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/901e09e50d8c9aa43ee92f654afaf17c32628479 901e09e50d8c9aa43ee92f654afaf17c32628479 2009-06-15T13:02:44-07:00 2009-06-15T13:02:31-07:00 Fix wrong memory access Found with valgrind. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> a8e8adca958d9be689bd63b03ddab4154b0bda01 Felipe Contreras felipe.contreras@gmail.com 3f40aebc1ab29801352866c187ebc081f7479d61 Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/b1a4a7c6c92d05a485e4d6438d6c23ebbbe9a60d b1a4a7c6c92d05a485e4d6438d6c23ebbbe9a60d 2009-05-30T11:20:03-07:00 2009-05-30T11:19:31-07:00 sb: set error properly So that we don't try to send 'OUT' when there's an error. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> ea40097979da12cc66aece8c9ab537ee262c5de0 Felipe Contreras felipe.contreras@gmail.com 144ccb0a585c8d3f15678d1c4721250880cc7573 Devid Antonio Filoni devidfil@gmail.com http://github.com/felipec/msn-pecan/commit/3f40aebc1ab29801352866c187ebc081f7479d61 3f40aebc1ab29801352866c187ebc081f7479d61 2009-05-30T07:30:47-07:00 2009-05-30T06:05:40-07:00 ab/pecan_contact.c: cleanup. d42a89281c588372ee9f9ca17021291ceaf50d3e Felipe Contreras felipe.contreras@gmail.com 7d64f2339ca4e71d9f10043c724f9134aefab124 Devid Antonio Filoni devidfil@gmail.com http://github.com/felipec/msn-pecan/commit/144ccb0a585c8d3f15678d1c4721250880cc7573 144ccb0a585c8d3f15678d1c4721250880cc7573 2009-05-30T07:30:47-07:00 2009-05-30T06:01:10-07:00 Set the passport also to session->user. c3a4a32b3e70c2ace75066f5a84d8c54b49a41c2 Felipe Contreras felipe.contreras@gmail.com 143f295b8bc4e00b4383f82c8a75d956f89fc869 Devid Antonio Filoni devidfil@gmail.com http://github.com/felipec/msn-pecan/commit/7d64f2339ca4e71d9f10043c724f9134aefab124 7d64f2339ca4e71d9f10043c724f9134aefab124 2009-05-30T07:30:47-07:00 2009-05-24T10:16:11-07:00 Show "You are not in A's contact list" message opening a conv window if needed. ddcc74786d110b31d04f0e0219902acbea899fdb Felipe Contreras felipe.contreras@gmail.com 34b301f18a52ff09a4287eb4133c4da125a412f9 Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/143f295b8bc4e00b4383f82c8a75d956f89fc869 143f295b8bc4e00b4383f82c8a75d956f89fc869 2009-05-30T07:30:47-07:00 2009-05-30T07:18:27-07:00 transaction: fix initial ref_count Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> 6b6a073363022c551c05b29ec0178c68dcf9d78d Felipe Contreras felipe.contreras@gmail.com 6db8d4b141a475878029f17117a707d66ffe648c Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/34b301f18a52ff09a4287eb4133c4da125a412f9 34b301f18a52ff09a4287eb4133c4da125a412f9 2009-05-30T06:35:12-07:00 2009-05-30T06:32:30-07:00 Properly ref/unref transactions Possibly fixes issue #133. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> 1c5b66ecd5c401bd671a56f3f1e72c447e92ceda Felipe Contreras felipe.contreras@gmail.com a53aca36c911c924710d52d4a575b2719a8bcb61 Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/6db8d4b141a475878029f17117a707d66ffe648c 6db8d4b141a475878029f17117a707d66ffe648c 2009-05-30T06:31:43-07:00 2009-05-30T06:31:43-07:00 transaction: add ref/unref Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> 1e586b464cfcc0e0697114bf86c049658de362d4 Felipe Contreras felipe.contreras@gmail.com fd5eb3dcb91b9f9f81ca804501259a10b76dfb86 Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/a53aca36c911c924710d52d4a575b2719a8bcb61 a53aca36c911c924710d52d4a575b2719a8bcb61 2009-05-30T06:31:20-07:00 2009-05-30T06:31:20-07:00 transaction: trivial cleanup Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> e717fd0ddaf56a6e7458f9747990d80fd1142a31 Felipe Contreras felipe.contreras@gmail.com d8546d4f49203f51b58a2f2315f89b0aa234b52a Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/fd5eb3dcb91b9f9f81ca804501259a10b76dfb86 fd5eb3dcb91b9f9f81ca804501259a10b76dfb86 2009-05-30T05:45:08-07:00 2008-06-29T11:41:27-07:00 Make sure the switchboard is not freed when it's still used by slplink. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> 334d6e17195fd2ec34b1e1353898aeb9eb2c8e44 Felipe Contreras felipe.contreras@gmail.com 16a0bb7bc495f4efd145889cfd922d4deb430ca2 Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/d8546d4f49203f51b58a2f2315f89b0aa234b52a d8546d4f49203f51b58a2f2315f89b0aa234b52a 2009-05-30T05:45:08-07:00 2008-06-28T10:44:10-07:00 Close the http node when not needed. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> 64b9ecaf6e02c2242c7094590034ab779c018a2a Felipe Contreras felipe.contreras@gmail.com a20747cd0ed42f7e2907a6e3d3277c7e661409c6 Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/16a0bb7bc495f4efd145889cfd922d4deb430ca2 16a0bb7bc495f4efd145889cfd922d4deb430ca2 2009-05-30T05:45:06-07:00 2008-06-24T06:31:16-07:00 Reorganize switchboard handling. Hopefully this would help fix issue #133. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> 1ce817d6e410de7bc0661fc440b5d83bd3b11214 Felipe Contreras felipe.contreras@gmail.com a6a23b8961769a77f58c56b1ca63f6fe83ef65ea Devid Antonio Filoni devidfil@gmail.com http://github.com/felipec/msn-pecan/commit/a20747cd0ed42f7e2907a6e3d3277c7e661409c6 a20747cd0ed42f7e2907a6e3d3277c7e661409c6 2009-05-30T05:04:09-07:00 2009-03-26T09:22:46-07:00 Add "Has Space" to get_info. a7a48674b705eab12b55ab2776696370ea9d05fa Felipe Contreras felipe.contreras@gmail.com aa0410bc8b2aab2b1e16de35fb7a36bd87ade33a Devid Antonio Filoni devidfil@gmail.com http://github.com/felipec/msn-pecan/commit/a6a23b8961769a77f58c56b1ca63f6fe83ef65ea a6a23b8961769a77f58c56b1ca63f6fe83ef65ea 2009-05-30T05:04:09-07:00 2009-03-26T08:26:59-07:00 Update MsnClientCaps in msn.h. 67e8084fe2557fee395ad31c8d8d77ea34d13f0f Felipe Contreras felipe.contreras@gmail.com e6f72b40bcf181beb9638d585d411481bfac7038 Devid Antonio Filoni devidfil@gmail.com http://github.com/felipec/msn-pecan/commit/aa0410bc8b2aab2b1e16de35fb7a36bd87ade33a aa0410bc8b2aab2b1e16de35fb7a36bd87ade33a 2009-05-30T05:04:08-07:00 2009-03-26T08:21:40-07:00 Add PURPLE_STATUS_TUNE support and parse contacts's CurrentMedia. Part of the code is taken from libpurple msn protocol. 4b7840bb1bd97d6f3e81829c19df6ca0ecc1d307 Felipe Contreras felipe.contreras@gmail.com f39209a53974bdb46075a05f76bc7eb0bba2cbe7 Devid Antonio Filoni devidfil@gmail.com http://github.com/felipec/msn-pecan/commit/e6f72b40bcf181beb9638d585d411481bfac7038 e6f72b40bcf181beb9638d585d411481bfac7038 2009-05-30T05:04:08-07:00 2009-03-26T08:23:38-07:00 Update COPYRIGHT. d1ba5eca237fe6505393be65005e3cfa0ace7238 Felipe Contreras felipe.contreras@gmail.com 9f6254f54c0110fb709d646fb1531e85dc8eaf99 Devid Antonio Filoni devidfil@gmail.com http://github.com/felipec/msn-pecan/commit/f39209a53974bdb46075a05f76bc7eb0bba2cbe7 f39209a53974bdb46075a05f76bc7eb0bba2cbe7 2009-05-30T05:04:06-07:00 2009-03-26T07:59:16-07:00 Move utils/msgplustags.{c,h} to pecan_util.{c,h}. Also fix some issues in the code. f174804c9e85f368769666632a35f4c622aa06c9 Felipe Contreras felipe.contreras@gmail.com 5a214809f88e68eadfa18a2996a7a0c983537d40 Geoffrey Antos geoffrey.antos@gmail.com http://github.com/felipec/msn-pecan/commit/9f6254f54c0110fb709d646fb1531e85dc8eaf99 9f6254f54c0110fb709d646fb1531e85dc8eaf99 2009-05-26T16:26:17-07:00 2009-05-26T16:26:17-07:00 slplink: fix buffer overflow vulnerability The issue stems from the fact that the body of an SLP message can have a different length than what the header claims. You make the check if (msg->msnslp_header.total_size < msg->msnslp_header.length) which uses declared length of the packet in the SLP header; however, the variable len does not originate from msg->msnslp_header.length, but is rather computed in msn_message_parse_payload and msn_message_parse_slp_body. No checks are made to ensure that msg->body_len == msg->msnslp_header.length. Thus, the vulnerability in question revolves around the situation in which len == msg->body_len > msg->msnslp_header.length As such, a malicious program can construct a SLP message sequence in the following manner: Send a new incomplete SLP message in which msnslp_header.session_id=SESSION_ID, msnslp_header.id=MESSAGE_ID, msnslp_header.offset = 0, and msnslp_header.length < msnslp_header.total_size. The SLP message is incomplete, which allows the attacker to send a second packet with a non-zero offset. For the purposes of this example, assume msnslp_header.length = 5 and msnslp_header.total_size = 10. Send the second message with same session and message ids msnslp_header.session_id=SESSION_ID, msnslp_header.id=MESSAGE_ID. However, send more data in the payload than the header specifies. For the purposes of the example, let us say msnslp_header.length = 5 and msnslp_header.total_size = 10 again, but this time the SLP message body is longer than the header specifies and contains a 1KiB of malicious data Thus msn_message_get_bin_data will set len = 1024. Furthermore, let us assume the attacker chooses offset = -2048 == 0xfffffffffffff800. The check performed is then evaluated as this: if ((gsize)offset > ((long long)slpmsg->size - (gsize)len)) On a system where gsize is 32 bits, offset gets truncated to 32 bits and this evaluates to if((gsize)0xfffff800 > (long long)-1014). 0xfffff800 is then implicitly converted back to a positive 64-bit integer, because an unsigned 32-bit value fits within the range of a signed 64-bit value, and the check works because the unsigned offset correctly doesn't get sign-extended. However, on a system where gsize and long long is 64 bits, this evaluates to if((gsize)0xfffffffffffff800 > (long long)-1014), the full untruncated offset specified in the packet. In this case, we have a 64-bit unsigned vs 64-bit signed comparison that GCC doesn't produce a warning for. Regardless of whether the compiler treats the result as signed or unsigned, the check is bypassed. 0xfffffffffffff800 > 0xfffffffffffffc0a and -2048 > -1014 are both false. Thus the memcpy line executes, writing the malicious data to buffer - 2048, well outside the 10 byte buffer allocated. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> 35215529e9bb75cc210edd20a11caa08769733a1 Felipe Contreras felipe.contreras@gmail.com 5f994f49ae16a22c3bf6efe1142a0cbae74571bd Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/5a214809f88e68eadfa18a2996a7a0c983537d40 5a214809f88e68eadfa18a2996a7a0c983537d40 2009-03-21T12:38:37-07:00 2009-03-21T12:38:37-07:00 fix_purple: rename purple_buddy_set functions As it was discussed and agreed long time ago with Pidgin developers. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> e05babafac31eaa9654a3b58f7e6a69fa754954f Felipe Contreras felipe.contreras@gmail.com 202d9ea4e2b36dacc88ab1be01d02ee648e67c5a Felipe Contreras felipe.contreras@gmail.com http://github.com/felipec/msn-pecan/commit/5f994f49ae16a22c3bf6efe1142a0cbae74571bd 5f994f49ae16a22c3bf6efe1142a0cbae74571bd 2009-03-21T12:33:46-07:00 2009-03-21T12:33:46-07:00 fix_purple: trivial cleanups Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> eb5e79895c1eaaa8cc964fb91f8cceb628bc20a5 Felipe Contreras felipe.contreras@gmail.com