exiting fish causes calling aplication to suspend

[maxfl]

This is an old and strange bug, which is not that harmful, but rather annoying.

One can use the following python code to illustrate it:

from os import system
system('fish')

In fish type exit and see the message:
Job 1, “ipython” has stopped
Then you need to call 'fg' to put the program back to foreground.

The same happens if I use subprocess module of if I use another languages (lua: 'os.execute "fish"').

[ridiculousfish]

I'm not able to reproduce this

[maxfl]

I've tested the latest version. The problem still exists.
Do you run on Mac? Can you try other systems/terminal emulators?

[siteshwar]

I am running Linux and able to reproduce this bug.

[smlx]

I am not able to reproduce this on debian wheezy. Possible regression?

Edit: scratch that. I see it now.

[ridiculousfish]

Oh, I see, you have to run the Python code from the repl. A script file won't reproduce it.

[ridiculousfish]

This code is triggering it:

/* Grab control of the terminal.  */
if( tcsetpgrp (STDIN_FILENO, shell_pgid) )

[ridiculousfish]

Minimal program that reproduces this:

#include <sys/types.h>
#include <unistd.h>
#include <stdio.h>
#include <signal.h>

int main(void) {
    setpgid(0, getpid());
    signal(SIGTTOU, SIG_IGN);
    tcsetpgrp (STDIN_FILENO, getpid());
    return 0;
}

[ridiculousfish]

I can reproduce these symptoms with other shells by sending them SIGKILL instead of allowing them to exit gracefully. I conclude they must be saving and restoring the process controlling terminal manually.

[ridiculousfish]

I added the same and it seems to fix the problem.

To git@github.com:fish-shell/fish-shell.git
b79854a..c9c2fc5 master -> master