iTerm2 does not set fish_title correctly for tabs

[ridiculousfish]

fish_title applies correctly to the window title, but not the tab title. This is due to this code in reader.cpp:

writestr( L"\x1b]2;" );

2: Window title
1: Tab title
0: Both window and tab title

I think removing the 2 is equivalent to setting it to 0, so that's probably what we ought to do.

[rdeits]

Confirmed--removing the 2 causes both the window and tab titles to be set. I've created a pull request: https://github.com/ridiculousfish/fishfish/pull/58

Thanks for your help!

[ridiculousfish]

#58 was merged.
Thanks for this report.