Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about taking autocomplete data from history command? #66

Closed
suhastech opened this issue Jun 7, 2012 · 5 comments
Closed

How about taking autocomplete data from history command? #66

suhastech opened this issue Jun 7, 2012 · 5 comments
Milestone

Comments

@suhastech
Copy link

Hi,

I'm big fan of autocomplete, have been using Ctrl + R quite frequently. I recently switched to fish. Even have it my .bashrc file.
It doesn't have the data from my previous shell. So, doesn't autocomplete yet. I think you guys can take the data from the history command?

@ridiculousfish
Copy link
Member

I think this is a request to initially populate history from bash.

@siteshwar
Copy link
Contributor

It's a good idea to import history from bash (and may be others shells too). But not all bash commands are valid fish commands. For e.g. 'export foo' is not valid in fish. We want to be as accurate as possible with our autosuggestions, and it's a different struggle to trasform (or may be ignore) invalid fish commands.

PS I have already done some work to import aliases, bash prompt and environment variables from bash. It's in import_config branch of our repository.

@ridiculousfish
Copy link
Member

Let's aim for a history importer that handles bash and fish 1.x

@ridiculousfish
Copy link
Member

fish now imports (most of) bash's history, if it cannot find its own history.

To git@github.com:fish-shell/fish-shell.git
69ace20..6f0b00f master -> master

@siteshwar
Copy link
Contributor

Instead of maintaining a list of commands which can not be imported from bash, may be we can just check whether a command is valid in fish. For e.g for builtins we can use builtin_exists() method

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants