@@ -1,5 +1,7 @@
require 'net/http'
require 'uri'
+$:.unshift(File.dirname(__FILE__)+'/../htmlentities/lib/')
+require 'htmlentities'
# post to tumblr.com -- see http://www.tumblr.com/api/
class BotSender::Tumblr < BotSender
@@ -16,7 +18,7 @@ class BotSender::Tumblr < BotSender
source = %Q[<a href="#{args[:url]}">#{source}</a>] if args[:url]
result = Net::HTTP.post_form(URI.parse(@post_url), {
:type => 'quote',
- :quote => (args[:quote] || ''),
+ :quote => HTMLEntities.new.encode(args[:quote] || ''),
:source => source,
:email => @email,
:password => @password
lib/senders/tumblr.rb
@@ -139,6 +139,13 @@ describe BotSender::Tumblr, "when posting a quote" do
@sender.do_quote(:quote => 'sibboleth, yo!', :source => 'ymendel')
end
+ it 'should escape HTML entities in the quote body' do
+ Net::HTTP.expects(:post_form).with do |url, args|
+ args[:quote] == 'xmlrpc = <win></win>'
+ end
+ @sender.do_quote(:quote => 'xmlrpc = <win></win>', :source => 'vinbarnes')
+ end
+
it "should set the quote source to the provided source" do
Net::HTTP.expects(:post_form).with do |url, args|
args[:source] == 'ymendel'
spec/bot_sender_tumblr_spec.rb
3e37750ffacb3cd760dd328601acc6f114e2343e
Yossef Mendelssohn
ymendel@pobox.com
http://github.com/flogic/nihilist_bot/commit/f97a3d87ca4584799c07a7cf0f5cb0657f7b7182
f97a3d87ca4584799c07a7cf0f5cb0657f7b7182
2008-07-30T17:57:23-07:00
2008-07-30T17:57:23-07:00
Encoding HTML entities in quotes when sending to Tumblr.
f3c0ffa8101218faab462636fa5cfadf6a5d845d
Yossef Mendelssohn
ymendel@pobox.com