Expect strings as arguments and to_i the revision.

Signed-off-by: François Beausoleil <francois@teksol.info>
francois · Aug 1, 2009 · 40c0bc4 · 40c0bc4
1 parent 93d9a95
commit 40c0bc4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/piston/svn/revision.rb b/lib/piston/svn/revision.rb
@@ -26,7 +26,7 @@ def checkout_to(dir)
         if answer =~ /Checked out revision (\d+)[.]/ then
           if revision == "HEAD" then
             @revision = $1.to_i
-          elsif revision != $1.to_i then
+          elsif revision.to_i != $1.to_i then
             raise InvalidRevision, "Did not get the revision I wanted to checkout.  Subversion checked out #{$1}, I wanted #{revision}"
           end
         else

diff --git a/test/unit/svn/revision/test_checkout.rb b/test/unit/svn/revision/test_checkout.rb
@@ -16,8 +16,8 @@ def test_head_checkout_to_path
   end
 
   def test_specific_revision_checkout_to_path
-    rev = new_revision(1231)
-    rev.expects(:svn).with(:checkout, "--revision", 1231, @repos.url, @wcdir).returns("Checked out revision 1231.")
+    rev = new_revision('1231')
+    rev.expects(:svn).with(:checkout, "--revision", '1231', @repos.url, @wcdir).returns("Checked out revision 1231.")
     rev.checkout_to(@wcdir)
   end