francois / piston fork watch download tarball
public
Description: Piston is a utility that eases vendor branch management. This repository is a complete reimplementation of Piston to provide different backends, depending on the repositories and working copies you pistonize from.
Homepage: http://piston.rubyforge.org/
Clone URL: git://github.com/francois/piston.git
Search Repo: 
Piston::WorkingCopy#remember_values requires 2 arguments now: values and 
handler_values.

Piston::Commands::Import was already passing 2 arguments, so it was a 
matter of updating the tests appropriately.  I did not use the single 
param variant anywhere anyway, so it was useless code.
francois (author)
Thu Apr 17 10:49:11 -0700 2008
commit  b6776eee6a822c7644b49807e3060d794fed93cf
tree    69bcafeae19b15c778f07deb9a0c1c55e0ee4c2b
parent  95c4d49e376dfbccdf97608c6c19fafe092bb7a4
0
lib/piston/working_copy.rb 
...
72
73
74
75
76
77
78
79
80
81
82
83
84
 
85
86
87
...
90
91
92
93
94
95
96
...
111
112
113
 
 
 
 
 
 
114
115
116
 
...
72
73
74
 
 
 
 
 
 
 
 
 
 
75
76
77
78
...
81
82
83
 
84
85
86
...
101
102
103
104
105
106
107
108
109
110
111
112
 
0
@@ -72,16 +72,7 @@
0
     end
0
 
0
     # Stores a Hash of values that can be retrieved later.
0
-    def remember(*args)
0
-      case args.length
0
-      when 1
0
-        values, handler_values = Hash.new, args.shift
0
-      when 2
0
-        values, handler_values = args.shift, args.shift
0
-      else
0
-        raise ArgumentError, "Piston::WorkingCopy#\remember expected 1 or 2 arguments, received #{args.length}"
0
-      end
0
-
0
+    def remember(values, handler_values)
0
       values["format"] = 1
0
 
0
       # Stringify keys
0
@@ -90,7 +81,6 @@
0
       end
0
 
0
       logger.debug {"Remembering #{values.inspect} as well as #{handler_values.inspect}"}
0
-      yaml_path = path + ".piston.yml"
0
       File.open(yaml_path, "wb") do |f|
0
         f.write(values.merge("handler" => handler_values).to_yaml)
0
       end
0
@@ -111,6 +101,12 @@
0
 
0
     def finalize
0
       logger.debug {"Finalizing #{path}"}
0
+    end
0
+
0
+    protected
0
+    # The path to the piston YAML file.
0
+    def yaml_path
0
+      path + ".piston.yml"
0
     end
0
   end
0
 end
0
test/unit/test_git_working_copy_rememberance.rb 
...
12
13
14
15
 
16
17
18
19
20
21
 
22
23
24
 
...
12
13
14
 
15
16
17
18
19
20
 
21
22
23
24
 
0
@@ -12,13 +12,13 @@
0
   end
0
 
0
   def test_creates_dot_piston_dot_yml_file
0
-    @wc.remember("a" => "b")
0
+    @wc.remember({}, "a" => "b")
0
     assert((@wcdir + ".piston.yml").exist?)
0
   end
0
 
0
   def test_writes_values_as_yaml_under_handler_key
0
     expected = {"a" => "b"}
0
-    @wc.remember(expected)
0
+    @wc.remember({}, expected)
0
     actual = YAML.load((@wcdir + ".piston.yml").read)
0
     assert_equal expected, actual["handler"]
0
   end
0
test/unit/test_working_copy_rememberance.rb 
...
13
14
15
16
 
17
18
19
20
21
22
 
23
24
25
26
27
28
29
 
30
31
32
 
...
13
14
15
 
16
17
18
19
20
21
 
22
23
24
25
26
27
28
 
29
30
31
32
 
0
@@ -13,20 +13,20 @@
0
   end
0
 
0
   def test_remember_generates_piston_yml_file_in_wc
0
-    @wc.remember("a" => "b")
0
+    @wc.remember({}, "a" => "b")
0
     assert((@wcdir + ".piston.yml").exist?, "tmp/wc/.piston.yml file doesn't exist")
0
   end
0
 
0
   def test_writes_values_as_yaml_under_handler_key
0
     expected = {"a" => "b"}
0
-    @wc.remember(expected)
0
+    @wc.remember({}, expected)
0
     actual = YAML.load((@wcdir + ".piston.yml").read)
0
     assert_equal expected, actual["handler"]
0
   end
0
 
0
   def test_remember_calls_after_remember_with_path_to_piston_yml_file
0
     @wc.expects(:after_remember).with(@wcdir + ".piston.yml")
0
-    @wc.remember("a" => "b")
0
+    @wc.remember({}, "a" => "b")
0
   end
0
 
0
   def test_remember_with_two_args_remembers_handler_values_separately

Comments

    No one has commented yet.