Fix the "get flashplayer" button. It was throwing a JS error before.

Not sure why it was done in JS in the first place. Fixes ticket #1256.
gallery · Jul 27, 2010 · 84a50e7 · 84a50e7
1 parent f9137c7
commit 84a50e7
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/modules/organize/views/organize_dialog.html.php b/modules/organize/views/organize_dialog.html.php
@@ -127,16 +127,14 @@ function getGalleryParameters() {
     <!-- The following spans are placeholders so we can load the hover and active styles for the flex component -->
     <span id="g-organize-hover" /><span id="g-organize-active" />
   <h1 style="display:none"><?= t("Organize :: %name", array("name" => html::purify($album->title))) ?></h1>
-    <div id="flashContent">
-      <p>
-        <?= t("To use the Organize feature, please ensure that Adobe Flash Player version %flash_minimum_version " .
-              "or greater is installed.", array("flash_minimum_version" => $flash_minimum_version)) ?>
-      </p>
-      <script type="text/javascript">
-	var pageHost = ((document.location.protocol == "https:") ? "https://" :	"http://");
-        $("#flashContent").append("<a href='http://www.adobe.com/go/getflashplayer'><img src='"	+ pageHost +
-                                  "www.adobe.com/images/shared/download_buttons/get_flash_player.gif' " +
-                                  "alt='<?= t("Get Adobe Flash Player") ?>' /></a>" );
-     </script>
-</div>
+  <div id="flashContent">
+    <p>
+      <?= t("To use the Organize feature, please ensure that Adobe Flash Player version %flash_minimum_version " .
+            "or greater is installed.", array("flash_minimum_version" => $flash_minimum_version)) ?>
+    </p>
+    <a href="http://www.adobe.com/go/getflashplayer">
+      <img src="<?= request::protocol() ?>://www.adobe.com/images/shared/download_buttons/get_flash_player.gif"
+           alt=<?= t("Get Adobe Flash Player")->for_js() ?> />
+    </a>
+  </div>
 </div>