Save on Document & ExtendedDocument crashed if bulk

- document#save expects to receive {"ok" => true} even with bulk mode - ExtendedDocument#save_without_callbacks reverted to previous code (expecting result["ok"] as in create_without_callbacks)
gentooboontoo · Oct 12, 2009 · 36f5f83 · 36f5f83 · tapajos · Jan 4, 2010
1 parent 54dee07
commit 36f5f83
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/couchrest/core/database.rb b/lib/couchrest/core/database.rb
@@ -145,7 +145,7 @@ def save_doc(doc, bulk = false)
       end
       if bulk
         @bulk_save_cache << doc
-        return bulk_save if @bulk_save_cache.length >= @bulk_save_cache_limit
+        bulk_save if @bulk_save_cache.length >= @bulk_save_cache_limit
         return {"ok" => true} # Compatibility with Document#save
       elsif !bulk && @bulk_save_cache.length > 0
         bulk_save

diff --git a/lib/couchrest/more/extended_document.rb b/lib/couchrest/more/extended_document.rb
@@ -238,7 +238,7 @@ def save_without_callbacks(bulk = false)
       set_unique_id if new? && self.respond_to?(:set_unique_id)
       result = database.save_doc(self, bulk)
       mark_as_saved 
-      true
+      result["ok"] == true
     end
 
     # Saves the document to the db using save. Raises an exception