spec/diff_false_positives/app/models/muppet_balls.rb @@ -15,6 +15,6 @@ class Array stepwise do |element1, element2| accumulator << element1 if yield(element1, element2) end - accumulator.compact + accumulator.compact.uniq end end lib/array.rb 2148419e7793570b6c1f8ffbda7638acc1d7ffbe Giles Bowkett gilesb@gmail.com http://github.com/gilesbowkett/towelie/commit/cf2449822b00b3e0c5d94d1eef94516e7b82f97f cf2449822b00b3e0c5d94d1eef94516e7b82f97f 2008-10-05T21:48:53-07:00 2008-10-05T21:48:53-07:00 Still getting false positives. I added more fake data to reflect this and recreate the bug, but no dice. Then I added the .uniq and the bug is gone. Unfortunately I can't just pop the data I found the bug with into git, because I'm using a few crufty client/ex-client apps to develop this on. I'm going to have to find where this bug came from, I think, because there's a good chance the .uniq won't work when I expand the diff stuff. Right now the diff is interesting but you have to do it directly via the codebase model, you can't do it via a Towelie object. No nice views, either, and the lack of useful metadata is a problem. For the diff to be useful, at a minimum, it has to say what a given method definition is different *from*. 0b927f39c6ae426c8490e7a20b2b84cabedf1456 Giles Bowkett gilesb@gmail.com