Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have custom guitools defined for git gui in a menu. #44

Closed
frogonwheels opened this issue Mar 24, 2010 · 8 comments
Closed

Have custom guitools defined for git gui in a menu. #44

frogonwheels opened this issue Mar 24, 2010 · 8 comments

Comments

@frogonwheels
Copy link
Contributor

It would be nice to be able to see (and edit) the tools defined for git gui in menus under git-cola.
For example:
guitool.Merge/Resolve All Merges.cmd=git mergetool --no-prompt

"Actions" menu could be a good place to put it.. or possibly its own.

@davvid
Copy link
Member

davvid commented Apr 7, 2010

commands: Add a RunConfigAction command

This implements the git guitool.*.cmd interface as documented
in git-config(1).

Closed by e9eb3aa

Suggested-by: frogonwheels via github
References: http://www.kernel.org/pub/software/scm/git/docs/git-config.html
Signed-off-by: David Aguilar davvid@gmail.com

@lkraav
Copy link

lkraav commented Jun 22, 2014

Are guitool launches supposed to be blocking git-cola GUI?

I'd like to define system wide guitools that keep git-cola functional, similar to Terminal and Editor launches.

davvid added a commit that referenced this issue Jun 25, 2014
Dynamically find the guitool config options instead of hard-coding their
names.

Related-to: #44

Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit that referenced this issue Jun 25, 2014
Setting `guitool.<name>.background` will now launch custom commands in
the background, which avoids blocking the UI.

Related-to: #44

Suggested-by: Leho Kraav <leho@kraav.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid
Copy link
Member

davvid commented Jun 25, 2014

@lkraav good idea! Now we can git config guitool.$name.background true and it'll launch in the command in the background.

@lkraav
Copy link

lkraav commented Jun 25, 2014

@lkraav
Copy link

lkraav commented Jun 25, 2014

Lots of goodies in 2.0.3+ now. Can you cut a 2.0.4? I don't think I'll be bugging you for a while after this.. everything's there! ;)

@davvid
Copy link
Member

davvid commented Jun 25, 2014

Thanks ;-) Yeah, it's just about time for the monthly release. I'll tag the repo before the end of the week for sure.

@lkraav
Copy link

lkraav commented Jul 4, 2014

I'm not entirely sure this is working correctly.

Simple guitool

/etc/gitconfig

[guitool "File Manager"]
    background = true
    cmd = urxvt -e ranger

When launching it, I get

Traceback (most recent call last):

File "/usr/share/git-cola/lib/cola/cmds.py", line 1343, in do_cmd
return cmd.do()

File "/usr/share/git-cola/lib/cola/cmds.py", line 981, in do
title = os.path.expandvars(cmd)

File "/usr/lib64/python3.3/posixpath.py", line 304, in expandvars
if '$' not in path:

TypeError: argument of type 'NoneType' is not iterable

davvid added a commit that referenced this issue Jul 5, 2014
We downcase the search pattern to match the case-ignoring behavior used
by "git config", but we did not also downcase the candidate string.

Downcase both so that we properly support having tool with mixed case
names.  Add a test to ensure the proper behavior.

Related-to: #44
Reported-by: Leho Kraav <leho@kraav.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid
Copy link
Member

davvid commented Jul 5, 2014

Thanks for the heads-up, it works with mixed-case names now.

davvid pushed a commit to davvid/git-cola that referenced this issue Jul 2, 2016
Make qtpy to set the QT_API environment variable
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants