Crash on "Get commit message template"

[diegorondini]

I get this crash when clicking on "Get commit message template". The crash doesn't however close the application.

https://bugzilla.redhat.com/show_bug.cgi?id=675721

backtrace

cmds.py:474:init:OSError: error: "None" does not exist

Traceback (most recent call last):
File "/usr/share/git-cola/lib/cola/qtutils.py", line 46, in broadcast
cola.notifier().broadcast(signal, _local_args, *_local_opts)
File "/usr/share/git-cola/lib/cola/notification.py", line 26, in broadcast
self.emit(signal, _args, *_opts)
File "/usr/share/git-cola/lib/cola/notification.py", line 32, in emit
fxn(_args, *_opts)
File "/usr/share/git-cola/lib/cola/cmdfactory.py", line 87, in run
return self.do(signal, _args, *_opts)
File "/usr/share/git-cola/lib/cola/cmdfactory.py", line 93, in do
cmdobj = cmdclass(_args, *_opts)
File "/usr/share/git-cola/lib/cola/cmds.py", line 492, in init
LoadCommitMessage.init(self, _config.get('commit.template'))
File "/usr/share/git-cola/lib/cola/cmds.py", line 474, in init
raise OSError('error: "%s" does not exist' % path)
OSError: error: "None" does not exist

Local variables in innermost frame:
path: None
self: <cola.cmds.LoadCommitTemplate object at 0x1fc4890>

[davvid]

cmds: Use 'UsageError' in the commit template command objects

Add error checking so that we can detect when users provide either
bad paths or unconfigured commit message templates.

Previously, an unconfigured "commit.template" git config variable
would result in a stacktrace. We now present users with a helpful
error message instead.

Closed by f9bb2c1

Signed-off-by: David Aguilar <davvid@gmail.com>