Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging files jumps file list instead of keeping focus on 'modified' items #97

Closed
tomasm- opened this issue Nov 10, 2011 · 0 comments
Closed

Staging files jumps file list instead of keeping focus on 'modified' items #97

tomasm- opened this issue Nov 10, 2011 · 0 comments
Labels
usability

Comments

@tomasm-
Copy link

tomasm- commented Nov 10, 2011

Every time I 'stage' a 'modified' file, the file list ("Repository Status") jumps to the top of the list, making any further 'modified' (unstaged) files out of view of my screen. I have to scroll back down the list for every file, and this gets annoying when I have 20-30+ files to stage. Wouldn't it make sense to just auto-advance to the next modified (unstaged) file, given that I've already said the staged file is ready to go? That way I don't have to scroll down again and again and again for each file I stage. The main task of Cola (for me) is to review and stage files, so IMO it should make it easy to review/stage any remaining files as I go through the list.

Thanks!
@davvid davvid closed this as completed in 952029b Nov 10, 2011
davvid added a commit to davvid/git-cola that referenced this issue Nov 21, 2011
@davvid
widgets.status: Refine selection behavior
cf2b516 
The selection behavior changed in 952029b
to not select items as they travel from staged to unstaged, and
vice versa.  This improved usability but interfered with the
partial staging workflow because partially staged files
were not re-selected.  Similarly, selecting multiple files and
hitting 'rescan' would lose the selection.

Improve these cases by reselecting files from the same
staged/unstaged category when they were previously selected.
This still addresses the usability issue from git-cola#97 because
we do not restore selection across the staged/unstaged boundary.

Further improve the interaction by optimizing the selection
behavior for code reviews.  When an unstaged item is staged
(and vice versa), the next item is automatically selected.

Closes git-cola#97

Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit to davvid/git-cola that referenced this issue Nov 21, 2011
@davvid
widgets.status: Further refine the selection behavior
73c059a 
Do not treat all 'unstaged' items as a singular entity.
Make sure that 'modified', 'unmerged', and 'untracked' are handled
separately so that no selection happens across these boundaries
when restoring the selection.

Closes git-cola#97

Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davvid @tomasm-