@@ -96,23 +96,16 @@ protected private def should_create_permalink? - if self.class.permalink_options[:if] - evaluate_method(self.class.permalink_options[:if]) - elsif self.class.permalink_options[:unless] - !evaluate_method(self.class.permalink_options[:unless]) - else + condition = self.class.permalink_options[:if] || self.class.permalink_options[:unless] + case condition + when nil true - end - end - - def evaluate_method(method) - case method when Symbol - send(method) + send(condition) when String - eval(method, instance_eval { binding }) + eval(condition, instance_eval { binding }) when Proc, Method - method.call(self) + condition.call(self) end end end lib/permalink_fu.rb d9d796cfa5a133eaa2382aacc3758e0f05b9c96a Pat Nakajima patnakajima@gmail.com http://github.com/github/permalink_fu/commit/1050fce6f2bb8c269bf08267a66ad22b29775c63 1050fce6f2bb8c269bf08267a66ad22b29775c63 2008-03-14T11:41:55-07:00 2008-03-14T11:41:55-07:00 moved condition evaluation into #should_create_permalink? method 2bd55dfcd18614514bc0e207da8810687c9b835f Pat Nakajima patnakajima@gmail.com