@@ -762,7 +762,7 @@ ngx_http_upstream_choose_fair_peer_idle(ngx_peer_connection_t *pc, } /* not in WM_IDLE+no_rr mode: the first completely idle backend gets chosen */ - if (weight_mode != WM_IDLE && !fp->peers->no_rr) { + if (weight_mode != WM_IDLE || !fp->peers->no_rr) { best_idx = n; break; } ngx_http_upstream_fair_module.c 8fac71e7fa02ad84b155e0c2e3f6c383ac950ba0 Grzegorz Nosek root@localdomain.pl http://github.com/gnosek/nginx-upstream-fair/commit/dc897c042014999694a0bcdbfa0a1b58adb84df6 dc897c042014999694a0bcdbfa0a1b58adb84df6 2008-10-12T08:51:16-07:00 2008-10-12T08:51:16-07:00 Silly logic bug in idle/no_rr mode checking Yay for De Morgan's laws. b2f16d471fba0c5b4ae3d131c8587e9d31fa6e13 Grzegorz Nosek root@localdomain.pl