Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: additional example for the taxonomies listing #2143

Closed
wants to merge 1 commit into from
Closed

docs: additional example for the taxonomies listing #2143

wants to merge 1 commit into from

Conversation

revelt
Copy link
Contributor

@revelt revelt commented May 13, 2016

Let's add another example how to list taxonomies inline, adding title (singular or plural) and commas between taxonomies.

Let's add another example how to list taxonomies inline, adding title (singular or plural) and commas between taxonomies.
@CLAassistant
Copy link

CLAassistant commented May 13, 2016

CLA assistant check
All committers have signed the CLA.

@revelt revelt changed the title additional example for the taxonomies listing docs: additional example for the taxonomies listing May 13, 2016
@digitalcraftsman
Copy link
Member

Hello @revelt,

thank you for submitting all the additions for the docs. If you want to separate multiple elements of a list you can use the delimit template function.

@revelt
Copy link
Contributor Author

revelt commented May 18, 2016

Hi @digitalcraftsman
Good observation! I chose the longer way to show how to create index variable. This is deliberately chosen example. If wiser people decides to put shorter version delimit I'm fine with that, I just feel more manual way is more educative. Would you go with shorter example using delimit, or longer manual way?

@digitalcraftsman
Copy link
Member

We could show both. You longer example in case users need to work with the indexes in one form or another. The shortcut with delimit would be used if the taxonomies should just listed with a separator.

anthonyfok pushed a commit that referenced this pull request Jun 30, 2016
Add another example how to list taxonomies inline,
adding title (singular or plural) and commas between taxonomies.

See #2143
anthonyfok added a commit that referenced this pull request Jun 30, 2016
anthonyfok pushed a commit that referenced this pull request Jun 30, 2016
Add another example how to list taxonomies inline,
adding title (singular or plural) and commas between taxonomies.

See #2143
anthonyfok added a commit that referenced this pull request Jun 30, 2016
@anthonyfok
Copy link
Member

Thank you for your contribution, @revelt!

Merged as 364686e (master) and 451d920 (v0.16.docs) after fixing the commit message per the contribution guideline.

I added a small paragraph (195a2b3 (master) and e53fc1c (v0.16.docs)) as a minimal way of addressing @digitalcraftsman's suggestion of using delimit as a shortcut when applicable. Feel free to expand it into an actual example if anyone wants to. :-)

@anthonyfok anthonyfok closed this Jun 30, 2016
tychoish pushed a commit to tychoish/hugo that referenced this pull request Aug 13, 2017
Add another example how to list taxonomies inline,
adding title (singular or plural) and commas between taxonomies.

See gohugoio#2143
tychoish pushed a commit to tychoish/hugo that referenced this pull request Aug 13, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants