New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tourism outline color #3582
Conversation
If you think that it is desirable - please open a new issue (if it is not existing already), it will be missed otherwise. |
I prefer orange over violet (see #3521 (comment)). In my opinion it would look more entertainment-like than violet which is currently used (in different shade) for industrial areas. |
Violet outline is not used for industrial areas (which BTW use lighter shade of violet anyway), so we reuse colors in a sane way. It also aligns nicely with attractions rendering, which makes it more consistent. Orange looks much lighter, so it could be used for something more "calm" than amusement. |
Id go with violet. Orange just doesn't make sense and violet looks better. Although it could be because of the (what I assume is) wrong park tagging color in the examples. Which go better with violet. Even so, violet seems to fit better with the other colors in general. Orange is better for something more natural, like trails in the woods or something (the one exception being gastronomy). |
Violet for me looks too close to administrative boundaries. |
@matkoniecz, is that an endorsement of orange then? |
@matkoniecz For me the difference is visible (this violet has more red shade and different line pattern), but I hope #3553 will make it even more clear soon. Unfortunately it makes the code dependency chain longer and more fragile (first #3553, then #3582 and after that #3521...). |
@matkoniecz do you think #660033 will work with the current admin
boundaries?
I believe this color is sufficiently dissimilar.
…On Sun, Dec 23, 2018 at 8:32 AM kocio-pl ***@***.***> wrote:
@matkoniecz <https://github.com/matkoniecz> For me the difference is
visible (this violet has more red shade and different line pattern), but I
hope #3553 <#3553>
will make it even more clear soon. Unfortunately it makes the code
dependency chain longer and more fragile (first #3553
<#3553>, then
#3582 <#3582> and
after that #3521
<#3521>...).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3582 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshGbA-oMeCSIfX47x9fv5fAwjL5VRks5u7sEkgaJpZM4Zbrjt>
.
|
I'd definitely go with violet over orange. |
Why about adding |
Thanks! I believe this is different enough from current border rendering and it's better to not hold the #3521 any longer. |
Would it make sense to move accommodation from the current transport-blue to the new tourism-violet? |
I'm afraid it's too close to the shops when using icons. |
|
Related to #3045 "Outline Coordination Meta Issue"
and #3521 "Add Aboriginal Areas"
Changes proposed in this pull request:
#660033
- this is currently the tourism=attraction text colorExplanation:
In #3521 it is planned to use brown for boundary=aboriginal_lands (eg American Indian reservations)
Therefore it is necessary to change the color of the outline used for zoos and theme parks.
This has also been desired, so that these tourist areas would be more visible on the map with a color more closely related to retail areas and other points of interest. The proposed change will also unify the color used for these two features with that used for tourism=attraction.
Purple and orange have also been discussed. Purple would work well, but would be more similar to the current administrative boundary rendering. Orange is another option.
Test renderings:
Singapore zoos
https://www.openstreetmap.org/#map=13/1.3950/103.8424
z17 Before
z17 After
z14 Before
z14 After
z13 Before
z13 After
Universal Studios Singapore
https://www.openstreetmap.org/#map=16/1.2546/103.8293
z16 before
z16 after
z17 before
z17 after
Jurong Bird Park, Singapore
https://www.openstreetmap.org/#map=15/1.3205/103.7153
z15 before
z15 after