Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tourism outline color #3582

Merged
merged 1 commit into from Dec 27, 2018
Merged

Conversation

jeisenbe
Copy link
Collaborator

@jeisenbe jeisenbe commented Dec 20, 2018

Related to #3045 "Outline Coordination Meta Issue"
and #3521 "Add Aboriginal Areas"

Changes proposed in this pull request:

  • Change tourism color from brown to #660033 - this is currently the tourism=attraction text color

Explanation:
In #3521 it is planned to use brown for boundary=aboriginal_lands (eg American Indian reservations)
Therefore it is necessary to change the color of the outline used for zoos and theme parks.
This has also been desired, so that these tourist areas would be more visible on the map with a color more closely related to retail areas and other points of interest. The proposed change will also unify the color used for these two features with that used for tourism=attraction.

Purple and orange have also been discussed. Purple would work well, but would be more similar to the current administrative boundary rendering. Orange is another option.

Test renderings:

Singapore zoos
https://www.openstreetmap.org/#map=13/1.3950/103.8424
z17 Before
z17-singapore-zoo-master
z17 After

  • Attractions within the zoom now are shown in the same color
  • I plan a PR to add generic icons (dots) for tourism=attraction
    z17-singapore-zoo-660033

z14 Before

  • Can compare to military areas here
    z14-singapore-zoo-master
    z14 After
    z14-singapore-zoo-660033

z13 Before

  • Compare to the international administrative boundary at this level (top of image)
  • Could we show zoos/theme parks with slightly smaller way_pixels at this zoom level?
    z13-zoos-master
    z13 After
    z13-zoos-660033

Universal Studios Singapore

z17 before
z17-universal-studios-master
z17 after
z17-universal-studios-660033

Jurong Bird Park, Singapore

@kocio-pl kocio-pl mentioned this pull request Dec 20, 2018
@matkoniecz
Copy link
Contributor

Could we show zoos/theme parks with slightly smaller way_pixels at this zoom level?

If you think that it is desirable - please open a new issue (if it is not existing already), it will be missed otherwise.

@Tomasz-W
Copy link

Tomasz-W commented Dec 21, 2018

I prefer orange over violet (see #3521 (comment)). In my opinion it would look more entertainment-like than violet which is currently used (in different shade) for industrial areas.

@kocio-pl
Copy link
Collaborator

Violet outline is not used for industrial areas (which BTW use lighter shade of violet anyway), so we reuse colors in a sane way. It also aligns nicely with attractions rendering, which makes it more consistent. Orange looks much lighter, so it could be used for something more "calm" than amusement.

@jeisenbe
Copy link
Collaborator Author

Here are some test images with the other color options. I think the current commit – with #660033 – is the best option. The dark violet option would probably require changing the the administrative border color, and lighter violet or purple would certainly require it.

Orange: #C77400
Zoos z14
z14-singapore-zoos-orange
z17
z17-singapore-zoo-orange

Bird Park z15
z15-jurong-orange

Universal Studios z16
z16-universal-studios-orange
z17
z17-universal-studios-orange

Dark Violet: #864784
Zoos z14
z14-singapore-zoo-darkviolet
z17
z17-universal-studios-darkviolet

Bird Park z15
z15-jurong-bird-darkviolet

Universal Studios z16
z16-universal-studios-darkviolet
z17
z17-universal-studios-darkviolet

(Thank Telkomsel for the great internet connection today)

@Adamant36
Copy link
Contributor

Adamant36 commented Dec 22, 2018

Id go with violet. Orange just doesn't make sense and violet looks better. Although it could be because of the (what I assume is) wrong park tagging color in the examples. Which go better with violet. Even so, violet seems to fit better with the other colors in general. Orange is better for something more natural, like trails in the woods or something (the one exception being gastronomy).

@matkoniecz
Copy link
Contributor

Violet for me looks too close to administrative boundaries.

@Adamant36
Copy link
Contributor

@matkoniecz, is that an endorsement of orange then?

@kocio-pl
Copy link
Collaborator

@matkoniecz For me the difference is visible (this violet has more red shade and different line pattern), but I hope #3553 will make it even more clear soon. Unfortunately it makes the code dependency chain longer and more fragile (first #3553, then #3582 and after that #3521...).

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Dec 23, 2018 via email

@turnsole80
Copy link

I'd definitely go with violet over orange.

@jragusa
Copy link
Contributor

jragusa commented Dec 26, 2018

Why about adding leisure=water_park (#1490) to the tourism outline ?

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Dec 27, 2018 via email

@kocio-pl kocio-pl merged commit 4d5f5a9 into gravitystorm:master Dec 27, 2018
@kocio-pl
Copy link
Collaborator

Thanks! I believe this is different enough from current border rendering and it's better to not hold the #3521 any longer.

@polarbearing
Copy link
Contributor

Would it make sense to move accommodation from the current transport-blue to the new tourism-violet?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 5, 2019

I'm afraid it's too close to the shops when using icons.

@polarbearing
Copy link
Contributor

#660033 tourism
#ac39ac shop-icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants