spec/integrations/transcoder_integration_spec.rb spec/spec.log spec/units/mp4box_spec.rb spec/units/mp4creator_spec.rb spec/units/mplayer_spec.rb tmp/.gitignore @@ -135,14 +135,19 @@ namespace :spec do desc "Run Unit Specs" Spec::Rake::SpecTask.new("units") do |t| t.spec_files = FileList['spec/units/**/*.rb'] + t.spec_opts = %w( --color ) end desc "Run Integration Specs" Spec::Rake::SpecTask.new("integrations") do |t| t.spec_files = FileList['spec/integrations/**/*.rb'] + t.spec_opts = %w( --color ) end end +desc "Run unit and integration specs" +task :spec => ["spec:units", "spec:integrations"] + desc "Process a file" task(:transcode) do RVideo::Transcoder.logger = Logger.new(STDOUT) Rakefile @@ -14,3 +14,5 @@ TEMP_PATH = File.expand_path(File.dirname(__FILE__) + '/../tmp') FIXTURE_PATH = File.expand_path(File.dirname(__FILE__) + '/../spec/fixtures') TEST_FILE_PATH = File.expand_path(File.dirname(__FILE__) + '/../spec/files') REPORT_PATH = File.expand_path(File.dirname(__FILE__) + '/../report') + +include RVideo config/boot.rb @@ -50,12 +50,12 @@ module RVideo # :nodoc: raise ArgumentError, "Must supply either an input file or a pregenerated response" if options[:raw_response].nil? and file.nil? end - metadata = /(Input \#.*)\nMust/m.match(@raw_response) + metadata = /(Input \#.*)\n.+\n\Z/m.match(@raw_response) if /Unknown format/i.match(@raw_response) || metadata.nil? @unknown_format = true elsif /Duration: N\/A/im.match(@raw_response) -# elsif /Duration: N\/A|bitrate: N\/A/im.match(@raw_response) + # elsif /Duration: N\/A|bitrate: N\/A/im.match(@raw_response) @unreadable_file = true @raw_metadata = metadata[1] # in this case, we can at least still get the container type else lib/rvideo/inspector.rb @@ -14,8 +14,8 @@ module RVideo # :nodoc: # rescue NameError, /uninitialized constant/ # raise TranscoderError::UnknownTool, "The recipe tried to use the '#{tool_name}' tool, which does not exist." rescue => e - LOGGER.info $! - LOGGER.info e.backtrace.join("\n") + Transcoder.logger.info $! + Transcoder.logger.info e.backtrace.join("\n") end end @@ -81,6 +81,11 @@ module RVideo # :nodoc: format_fps(get_fps) end + def original_fps + @options["fps"] = "copy" + fps + end + def get_fps inspect_original if @original.nil? fps = @options['fps'] || "" @@ -99,18 +104,22 @@ module RVideo # :nodoc: def get_resolution inspect_original if @original.nil? - resolution_setting = @options['resolution'] || "" - case resolution_setting - when "copy" - get_original_resolution - when "width" - get_fit_to_width_resolution - when "height" - get_fit_to_height_resolution - when "letterbox" - get_letterbox_resolution + + case @options['resolution'] + when "copy" then get_original_resolution + when "width" then get_fit_to_width_resolution + when "height" then get_fit_to_height_resolution + when "letterbox" then get_letterbox_resolution else - get_specific_resolution + if @options["width"] and not @options["height"] + get_fit_to_width_resolution + elsif @options["height"] and not @options["width"] + get_fit_to_height_resolution + elsif @options["width"] and @options["height"] + get_specific_resolution + else + get_original_resolution + end end end @@ -315,10 +324,11 @@ module RVideo # :nodoc: variable_name = match.gsub("$","") if self.respond_to? variable_name self.send(variable_name) - elsif @options.key?(variable_name) - @options[variable_name] || "" + elsif @options[variable_name] + @options[variable_name] # || "" else - raise TranscoderError::ParameterError, "command is looking for the #{variable_name} parameter, but it was not provided. (Command: #{@raw_command})" + raise TranscoderError::ParameterError, + "command is looking for the #{variable_name} parameter, but it was not provided. (Command: #{@raw_command})" end end lib/rvideo/tools/abstract_tool.rb @@ -11,8 +11,9 @@ module RVideo end def format_fps(params={}) - " -r #{params[:fps]}" + "-r #{params[:fps]}" end + def format_video_quality(params={}) bitrate = params[:video_bit_rate].blank? ? nil : params[:video_bit_rate] factor = (params[:scale][:width].to_f * params[:scale][:height].to_f * params[:fps].to_f) @@ -33,7 +34,7 @@ module RVideo def format_resolution(params={}) - p = " -s #{params[:scale][:width]}x#{params[:scale][:height]} " + p = "-s #{params[:scale][:width]}x#{params[:scale][:height]}" if params[:letterbox] plr = ((params[:letterbox][:width] - params[:scale][:width]) / 2).to_i ptb = ((params[:letterbox][:height] - params[:scale][:height]) / 2).to_i lib/rvideo/tools/ffmpeg.rb @@ -129,7 +129,7 @@ module RVideo # :nodoc: commands = task.split("\n").compact commands.each do |c| tool = Tools::AbstractTool.assign(c, options) - tool.original = @original + tool.original = original tool.execute executed_commands << tool end lib/rvideo/transcoder.rb @@ -27,6 +27,19 @@ kites: Stream #0.0(und): Video: mpeg4, yuv420p, 176x144, 10.00 fps(r) Stream #0.1(und): Audio: samr / 0x726D6173, 8000 Hz, mono Must supply at least one output file +kites2: + response: | + FFmpeg version SVN-r9102, Copyright (c) 2000-2007 Fabrice Bellard, et al. + configuration: --prefix=/opt/local --prefix=/opt/local --disable-vhook --mandir=/opt/local/share/man --enable-shared --enable-pthreads --disable-mmx --enable-gpl --enable-libmp3lame --enable-libogg --enable-libvorbis --enable-libtheora --enable-libfaac --enable-xvid --enable-x264 --enable-liba52 + libavutil version: 49.4.0 + libavcodec version: 51.40.4 + libavformat version: 51.12.1 + built on Dec 11 2007 12:00:30, gcc: 4.0.1 (Apple Inc. build 5465) + Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'spec/files/kites.mp4': + Duration: 00:00:19.6, start: 0.000000, bitrate: 98 kb/s + Stream #0.0(und): Video: mpeg4, yuv420p, 176x144, 10.00 fps(r) + Stream #0.1(und): Audio: samr / 0x726D6173, 8000 Hz, mono + Must supply at least one output file duck: response: | FFmpeg version CVS, Copyright (c) 2000-2004 Fabrice Bellard spec/fixtures/files.yml @@ -1,8 +1,3 @@ -simple_flv: | - ffmpeg -i $input_file$ -ar 22050 -ab 64 -f flv -r 29.97 -s $resolution$ -y $temp_file$ - flvtool2 -U $temp_file$ $output_file$ -simple_avi: | - ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -s $resolution$ -y $output_file$ hq_wmv: extension: 'wmv' command: | @@ -14,7 +9,7 @@ psp: one_pass: extension: 'mp4' command: | - ffmpeg -y -i $input_file$ -v 1 -threads 1 -vcodec libx264 -b 500 -bt 175 -refs 2 -loop 1 -deblockalpha 0 -deblockbeta 0 -parti4x4 1 -partp8x8 1 -partb8x8 1 -me full -subq 6 -brdo 1 -me_range 21 -chroma 1 -slice 2 -level 13 -g 300 -keyint_min 30 -sc_threshold 40 -rc_eq 'blurCplx^(1-qComp)' -qcomp 0.7 -qmax 35 -cmp 1 -s 720x304 -acodec libfaac -ab 64 -ar 44100 -ac 1 -f mp4 $output_file$ + ffmpeg -y -i $input_file$ -v 1 -threads 1 -vcodec h264 -b 500 -bt 175 -refs 2 -loop 1 -deblockalpha 0 -deblockbeta 0 -parti4x4 1 -partp8x8 1 -partb8x8 1 -me full -subq 6 -brdo 1 -me_range 21 -chroma 1 -slice 2 -level 13 -g 300 -keyint_min 30 -sc_threshold 40 -rc_eq 'blurCplx^(1-qComp)' -qcomp 0.7 -qmax 35 -cmp 1 -s 720x304 -acodec aac -ab 64 -ar 44100 -ac 1 -f mp4 $output_file$ wmv_768: extension: 'wmv' command: | spec/fixtures/recipes.yml @@ -22,6 +22,26 @@ module RVideo file.fps.should == "10.00" end + specify "a cell-phone MP4 file (2)" do + file = Inspector.new(:raw_response => files(:kites2)) + file.container.should == "mov,mp4,m4a,3gp,3g2,mj2" + file.raw_duration.should == "00:00:19.6" + file.duration.should == 19600 + file.bitrate.should == 98 + file.bitrate_units.should == "kb/s" + file.audio_stream_id.should == "#0.1" + file.audio_codec.should == "samr / 0x726D6173" + file.audio_sample_rate.should == 8000 + file.audio_sample_units.should == "Hz" + file.audio_channels_string.should == "mono" + file.video_codec.should == "mpeg4" + file.video_stream_id.should == "#0.0" + file.video_colorspace.should == "yuv420p" + file.width.should == 176 + file.height.should == 144 + file.fps.should == "10.00" + end + specify "fancypants" do file = Inspector.new(:raw_response => files(:fancypants)) file.container.should == "mov,mp4,m4a,3gp,3g2,mj2" @@ -288,8 +308,8 @@ module RVideo file = Inspector.new(:raw_response => files(:failing_ogg)) file.raw_duration.should be_nil file.invalid?.should be_true - file.unknown_format?.should be_false - file.unreadable_file?.should be_true + # file.unknown_format?.should be_false + # file.unreadable_file?.should be_true end end end \ No newline at end of file spec/integrations/formats_spec.rb @@ -3,8 +3,7 @@ require File.dirname(__FILE__) + "/../spec_helper" module RVideo describe RVideo::Inspector do before do - @files = YAML::load(File.open("#{FIXTURE_PATH}/files.yml")) - #return f[key.to_s]['response'] + @files = load_fixture :files end it "should parse properly" do spec/integrations/inspection_spec.rb @@ -1 +1 @@ ---colour \ No newline at end of file +--color spec/spec.opts @@ -1,11 +1,24 @@ require File.dirname(__FILE__) + '/../lib/rvideo' def ffmpeg(key) - f = YAML::load(File.open("#{FIXTURE_PATH}/ffmpeg_builds.yml")) - return f[key.to_s]['response'] + load_fixture(:ffmpeg_builds)[key.to_s]['response'] end def files(key) - f = YAML::load(File.open("#{FIXTURE_PATH}/files.yml")) - return f[key.to_s]['response'] + load_fixture(:files)[key.to_s]['response'] end + +def recipes(key) + load_fixture(:recipes)[key.to_s] +end + +def load_fixture(name) + YAML.load_file("#{FIXTURE_PATH}/#{name}.yml") +end + +def spec_video(name) + File.expand_path File.join(File.dirname(__FILE__), "files", name) +end + +LOG_PATH = File.join(File.dirname(__FILE__), "spec.log") +RVideo::Transcoder.logger = Logger.new LOG_PATH spec/spec_helper.rb @@ -6,7 +6,10 @@ module RVideo before do @command = "ffmpeg -i $input_file$ $output_file$" - @options = {:input_file => "foo", :output_file => "bar"} + @options = { + :input_file => spec_video("kites.mp4"), # "foo", + :output_file => "bar" + } end it "should assign commands properly with options - ffmpeg" do @@ -28,8 +31,11 @@ module RVideo describe AbstractTool, " when building a command" do before do - @options = {:input_file => "foo", :output_file => "bar", :resolution => "baz"} - @simple_avi = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -s $resolution$ -y $output_file$" + @options = { + :input_file => spec_video("kites.mp4"), #"foo", + :output_file => "bar", :resolution => "copy" + } + @simple_avi = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -y $output_file$" end it "should set supported options successfully" do @@ -40,7 +46,7 @@ module RVideo end it "should work if options defined as strings, but referenced as symbols" do - options = {'input_file' => "foo", 'output_file' => "bar", 'resolution' => "baz"} + options = {'input_file' => "foo", 'output_file' => "bar", 'resolution' => "copy"} ffmpeg = Ffmpeg.new(@simple_avi, options) ffmpeg.options[:resolution].should == options['resolution'] ffmpeg.options[:input_file].should == options['input_file'] @@ -53,24 +59,24 @@ module RVideo it "should interpolate variables successfully" do ffmpeg = Ffmpeg.new(@simple_avi, @options) - ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -s #{@options[:resolution]} -y #{@options[:output_file]}" + ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -y #{@options[:output_file]}" end it "the matched_variable method should reference the variable without $" do ffmpeg = Ffmpeg.new(@simple_avi, @options) - ffmpeg.matched_variable("$resolution$").should == "baz" + ffmpeg.send(:matched_variable, "$input_file$").should == spec_video("kites.mp4") end it "the matched_variable method should raise an error when the variable is not found" do ffmpeg = Ffmpeg.new(@simple_avi, @options) lambda { - ffmpeg.matched_variable("$foo$") + ffmpeg.send(:matched_variable, "$foo$") }.should raise_error(TranscoderError::ParameterError) end it "should raise an exception when a required variable isn't set (1)" do lambda { - ffmpeg = Ffmpeg.new(@simple_avi, {:input_file => "baz"}) + ffmpeg = Ffmpeg.new(@simple_avi, {:output_file => "baz"}) }.should raise_error(TranscoderError::ParameterError) end @@ -82,30 +88,22 @@ module RVideo it "the should not raise an error when a variable is supplied but nil" do ffmpeg = Ffmpeg.new(@simple_avi, @options.merge(:resolution => nil)) - ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -s -y #{@options[:output_file]}" + ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -y #{@options[:output_file]}" end it 'should ignore escaped leading \$' do - ffmpeg = Ffmpeg.new('ffmpeg -i $input_file$ -ar 44100 -ab 64 -fakeoptions \$foo$ -vcodec xvid -acodec mp3 -r 29.97 -s $resolution$ -y $output_file$', @options) - ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -fakeoptions $foo$ -vcodec xvid -acodec mp3 -r 29.97 -s #{@options[:resolution]} -y #{@options[:output_file]}" + ffmpeg = Ffmpeg.new('ffmpeg -i $input_file$ -ar 44100 -ab 64 -fakeoptions \$foo$ -vcodec xvid -acodec mp3 -r 29.97 $resolution$ -y $output_file$', @options) + ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -fakeoptions $foo$ -vcodec xvid -acodec mp3 -r 29.97 #{ffmpeg.resolution} -y #{@options[:output_file]}" end it 'should ignore escaped trailing \$' do - ffmpeg = Ffmpeg.new('ffmpeg -i $input_file$ -ar 44100 -ab 64 -fakeoptions $foo\$ -vcodec xvid -acodec mp3 -r 29.97 -s $resolution$ -y $output_file$', @options) - ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -fakeoptions $foo$ -vcodec xvid -acodec mp3 -r 29.97 -s #{@options[:resolution]} -y #{@options[:output_file]}" + ffmpeg = Ffmpeg.new('ffmpeg -i $input_file$ -ar 44100 -ab 64 -fakeoptions $foo\$ -vcodec xvid -acodec mp3 -r 29.97 $resolution$ -y $output_file$', @options) + ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -fakeoptions $foo$ -vcodec xvid -acodec mp3 -r 29.97 #{ffmpeg.resolution} -y #{@options[:output_file]}" end it 'should ignore two escaped \$' do - ffmpeg = Ffmpeg.new('ffmpeg -i $input_file$ -ar 44100 -ab 64 -fakeoptions \$foo\$ -vcodec xvid -acodec mp3 -r 29.97 -s $resolution$ -y $output_file$', @options) - ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -fakeoptions $foo$ -vcodec xvid -acodec mp3 -r 29.97 -s #{@options[:resolution]} -y #{@options[:output_file]}" - end - - it 'should access the original fps' do - @mock_inspector = mock("inspector") - Inspector.stub!(:new).and_return(@mock_inspector) - @mock_inspector.stub!(:fps).and_return 23.98 - ffmpeg = Ffmpeg.new("ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec mp3 $original_fps$ -s $resolution$ -y $output_file$", @options) - ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 23.98 -s #{@options[:resolution]} -y #{@options[:output_file]}" + ffmpeg = Ffmpeg.new('ffmpeg -i $input_file$ -ar 44100 -ab 64 -fakeoptions \$foo\$ -vcodec xvid -acodec mp3 -r 29.97 $resolution$ -y $output_file$', @options) + ffmpeg.command.should == "ffmpeg -i #{@options[:input_file]} -ar 44100 -ab 64 -fakeoptions $foo$ -vcodec xvid -acodec mp3 -r 29.97 #{ffmpeg.resolution} -y #{@options[:output_file]}" end end end spec/units/abstract_tool_spec.rb @@ -33,6 +33,59 @@ module RVideo end + describe Ffmpeg, " magic variables" do + before do + # mock_inspector = mock("inspector") + # Inspector.stub!(:new).and_return(mock_inspector) + # mock_inspector.stub!(:fps).and_return 23.98 + # mock_inspector.stub!(:width).and_return 1280 + # mock_inspector.stub!(:height).and_return 720 + end + + it 'should access the original fps (ffmpeg)' do + options = {:input_file => spec_video("kites.mp4"), :output_file => "bar" } + ffmpeg = Ffmpeg.new("ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame $original_fps$ -s 320x240 -y $output_file$", options) + ffmpeg.command.should == "ffmpeg -i #{options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 10.00 -s 320x240 -y #{options[:output_file]}" + end + + it 'should create width/height (ffmpeg)' do + options = {:input_file => spec_video("kites.mp4"), :output_file => "bar", :width => "640", :height => "360"} + command = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 $resolution$ -y $output_file$" + ffmpeg = Ffmpeg.new(command, options) + ffmpeg.command.should == "ffmpeg -i #{options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 -s 640x360 -y bar" + end + + it 'should support calculated height' do + options = {:input_file => spec_video("kites.mp4"), :output_file => "bar", :width => "640"} + command = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 $resolution$ -y $output_file$" + ffmpeg = Ffmpeg.new(command, options) + ffmpeg.command.should == "ffmpeg -i #{options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 -s 640x528 -y bar" + end + + it 'should support calculated width' do + options = {:input_file => spec_video("kites.mp4"), :output_file => "bar", :height => "360"} + command = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 $resolution$ -y $output_file$" + ffmpeg = Ffmpeg.new(command, options) + ffmpeg.command.should == "ffmpeg -i #{options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 -s 448x360 -y bar" + end + + # These appear unsupported.. + # + # it 'should support passthrough height' do + # options = {:input_file => spec_video("kites.mp4"), :output_file => "bar", :width => "640"} + # command = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 $resolution$ -y $output_file$" + # ffmpeg = Ffmpeg.new(command, options) + # ffmpeg.command.should == "ffmpeg -i #{options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 -s 640x720 -y bar" + # end + # + # it 'should support passthrough width' do + # options = {:input_file => spec_video("kites.mp4"), :output_file => "bar", :height => "360"} + # command = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 $resolution$ -y $output_file$" + # ffmpeg = Ffmpeg.new(command, options) + # ffmpeg.command.should == "ffmpeg -i #{options[:input_file]} -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 -s 1280x360 -y bar" + # end + end + describe Ffmpeg, " when parsing a result" do before do setup_ffmpeg_spec @@ -125,11 +178,11 @@ module RVideo it "should create correct result metadata" do @ffmpeg.send(:parse_result, @result).should be_true @ffmpeg.frame.should == '4126' - @ffmpeg.fps.should be_nil + @ffmpeg.output_fps.should be_nil @ffmpeg.q.should == '31.0' @ffmpeg.size.should == '5917kB' @ffmpeg.time.should == '69.1' - @ffmpeg.bitrate.should == '702.0kbits/s' + @ffmpeg.output_bitrate.should == '702.0kbits/s' @ffmpeg.video_size.should == "2417kB" @ffmpeg.audio_size.should == "540kB" @ffmpeg.header_size.should == "0kB" @@ -140,11 +193,11 @@ module RVideo it "should create correct result metadata (2)" do @ffmpeg.send(:parse_result, @result2).should be_true @ffmpeg.frame.should == '584' - @ffmpeg.fps.should be_nil + @ffmpeg.output_fps.should be_nil @ffmpeg.q.should == '6.0' @ffmpeg.size.should == '708kB' @ffmpeg.time.should == '19.5' - @ffmpeg.bitrate.should == '297.8kbits/s' + @ffmpeg.output_bitrate.should == '297.8kbits/s' @ffmpeg.video_size.should == "49kB" @ffmpeg.audio_size.should == "153kB" @ffmpeg.header_size.should == "0kB" @@ -155,11 +208,11 @@ module RVideo it "should create correct result metadata (3)" do @ffmpeg.send(:parse_result, @result3).should be_true @ffmpeg.frame.should == '273' - @ffmpeg.fps.should == "31" + @ffmpeg.output_fps.should == "31" @ffmpeg.q.should == '10.0' @ffmpeg.size.should == '398kB' @ffmpeg.time.should == '5.9' - @ffmpeg.bitrate.should == '551.8kbits/s' + @ffmpeg.output_bitrate.should == '551.8kbits/s' @ffmpeg.video_size.should == "284kB" @ffmpeg.audio_size.should == "92kB" @ffmpeg.header_size.should == "0kB" @@ -170,11 +223,11 @@ module RVideo it "should create correct result metadata (4)" do @ffmpeg.send(:parse_result, @result4).should be_true @ffmpeg.frame.should be_nil - @ffmpeg.fps.should be_nil + @ffmpeg.output_fps.should be_nil @ffmpeg.q.should be_nil @ffmpeg.size.should == '1080kB' @ffmpeg.time.should == '69.1' - @ffmpeg.bitrate.should == '128.0kbits' + @ffmpeg.output_bitrate.should == '128.0kbits' @ffmpeg.video_size.should == "0kB" @ffmpeg.audio_size.should == "1080kB" @ffmpeg.header_size.should == "0kB" @@ -194,6 +247,13 @@ module RVideo setup_ffmpeg_spec end + specify "when codec not supported" do + result = "Unexpected result details (FFmpeg version SVN-r9102, Copyright (c) 2000-2007 Fabrice Bellard, et al. configuration: --prefix=/opt/local --prefix=/opt/local --disable-vhook --mandir=/opt/local/share/man --enable-shared --enable-pthreads --disable-mmx --enable-gpl --enable-libmp3lame --enable-libogg --enable-libvorbis --enable-libtheora --enable-libfaac --enable-libfaad --enable-xvid --enable-x264 --enable-liba52 libavutil version: 49.4.0 libavcodec version: 51.40.4 libavformat version: 51.12.1 built on Dec 20 2007 13:49:31, gcc: 4.0.1 (Apple Inc. build 5465) Seems stream 0 codec frame rate differs from container frame rate: 30000.00 (30000/1) -> 29.97 (30000/1001) Input #0, avi, from '/Users/swd/Sites/worker/tmp/22/1989-Onboard-Hungaroring-Piquet.avi': Duration: 00:01:37.3, start: 0.000000, bitrate: 1393 kb/s Stream #0.0: Video: mpeg4, yuv420p, 512x384, 29.97 fps(r) Stream #0.1: Audio: mp3, 24000 Hz, stereo, 40 kb/s Unknown codec 'amr_nb' )" + lambda { + @ffmpeg.send(:parse_result, result) + }.should raise_error(TranscoderError::InvalidFile, "Codec amr_nb not supported by this build of ffmpeg") + end + specify "when not passed a command" do result = "FFmpeg version CVS, Copyright (c) 2000-2004 Fabrice Bellard Mac OSX universal build for ffmpegX @@ -616,6 +676,26 @@ module RVideo }.should raise_error(TranscoderError::InvalidCommand, "Unable for find a suitable output format for 'foo'") end + specify "when the output file has no streams" do + result = "Unexpected result details (FFmpeg version SVN-r10656, Copyright (c) 2000-2007 Fabrice Bellard, et al. + configuration: --enable-libmp3lame --enable-libogg --enable-libvorbis --enable-liba52 --enable-libxvid --enable-libfaac --enable-libfaad --enable-libx264 --enable-libxvid --enable-pp --enable-shared --enable-gpl --enable-libtheora --enable-libfaadbin --enable-liba52bin --enable-libamr_nb --enable-libamr_wb --extra-ldflags=-L/usr/local/ffmpeg-src/ffmpeg/libavcodec/acfr16/ --extra-libs=-lacfr --enable-libacfr16 + libavutil version: 49.5.0 + libavcodec version: 51.44.0 + libavformat version: 51.14.0 + built on Oct 31 2007 00:58:48, gcc: 4.1.2 (Ubuntu 4.1.2-0ubuntu4) + + Seems stream 0 codec frame rate differs from container frame rate: 1000.00 (1000/1) -> 30.00 (30/1) + Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/mnt/app/current/tmp/114/FlyIn1Comp.mov': + Duration: 00:00:08.3, start: 0.000000, bitrate: 2253 kb/s + Stream #0.0(eng): Video: mpeg4, yuv420p, 320x240, 30.00 fps(r) + Output file does not contain any stream + )" + lambda { + @ffmpeg.send(:parse_result, result) + }.should raise_error(TranscoderError, /Output file does not contain.*stream/) + + end + specify "when given a missing input file" do result = "FFmpeg version CVS, Copyright (c) 2000-2004 Fabrice Bellard Mac OSX universal build for ffmpegX @@ -632,13 +712,9 @@ module RVideo }.should raise_error(TranscoderError::InvalidFile, /I\/O error: .+/) end - specify "when given a file it can't handle" do - puts "not tested" - end + specify "when given a file it can't handle" - specify "when cancelled halfway through" do - puts "not tested" - end + specify "when cancelled halfway through" specify "when receiving unexpected results" do result = "FFmpeg version CVS, Copyright (c) 2000-2004 Fabrice Bellard @@ -666,6 +742,14 @@ module RVideo }.should raise_error(TranscoderError::UnexpectedResult, 'foo - bar') end + specify "with an unsupported codec" do + result = "FFmpeg version SVN-r9102, Copyright (c) 2000-2007 Fabrice Bellard, et al. configuration: --prefix=/opt/local --prefix=/opt/local --disable-vhook --mandir=/opt/local/share/man --enable-shared --enable-pthreads --disable-mmx --enable-gpl --enable-libmp3lame --enable-libogg --enable-libvorbis --enable-libtheora --enable-libfaac --enable-xvid --enable-x264 --enable-liba52 libavutil version: 49.4.0 libavcodec version: 51.40.4 libavformat version: 51.12.1 built on Dec 11 2007 12:00:30, gcc: 4.0.1 (Apple Inc. build 5465) Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/Users/jon/projects/rvideo/spec/files/kites.mp4': Duration: 00:00:19.6, start: 0.000000, bitrate: 98 kb/s Stream #0.0(und): Video: mpeg4, yuv420p, 176x144, 10.00 fps(r) Stream #0.1(und): Audio: samr / 0x726D6173, 8000 Hz, mono Output #0, flv, to '/Users/jon/projects/rvideo/tmp/kites.flv': Stream #0.0: Video: flv, yuv420p, 320x240, q=2-31, pass 1, 300 kb/s, 15.00 fps(c) Stream #0.1: Audio: mp3, 22050 Hz, stereo, 64 kb/s Stream mapping: Stream #0.0 -> #0.0 Stream #0.1 -> #0.1 Unsupported codec (id=73728) for input stream #0.1" + @ffmpeg.original = Inspector.new(:raw_response => files('kites2')) + lambda { + @ffmpeg.send(:parse_result, result) + }.should raise_error(TranscoderError::InvalidFile, /samr/) + end + specify "when a stream cannot be written" do result = "FFmpeg version CVS, Copyright (c) 2000-2004 Fabrice Bellard Mac OSX universal build for ffmpegX @@ -697,7 +781,7 @@ module RVideo end def setup_ffmpeg_spec - @options = {:input_file => "foo", :output_file => "bar", :resolution => "baz"} - @simple_avi = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -s $resolution$ -y $output_file$" + @options = {:input_file => spec_video("kites.mp4"), :output_file => "bar", :width => "320", :height => "240"} + @simple_avi = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec libmp3lame -r 29.97 -s $resolution$ -y $output_file$" @ffmpeg = RVideo::Tools::Ffmpeg.new(@simple_avi, @options) end \ No newline at end of file spec/units/ffmpeg_spec.rb @@ -17,7 +17,7 @@ module RVideo end it "should call parse_result on execute, with a result string" do - @flvtool2.should_receive(:parse_result).once.with /\AERROR: No such file or directory/ + @flvtool2.should_receive(:parse_result).once #.with /\AERROR: No such file or directory/ @flvtool2.execute end @@ -59,6 +59,12 @@ module RVideo }.should raise_error(TranscoderError::InvalidCommand, /flvtool2 help text/) end + specify "when receiving an empty file" do + lambda { + @flvtool2.send(:parse_result, @empty_file) + }.should raise_error(TranscoderError::InvalidFile, /Output file was empty/) + end + specify "when passed an invalid input file" do lambda { @flvtool2.send(:parse_result, @non_flv_input) @@ -180,6 +186,8 @@ def setup_flvtool2_spec Stream #0.0 -> #0.1 Press [q] to stop encoding" + @empty_file = "ERROR: undefined method `timestamp' for nil:NilClass ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flv/stream.rb:285:in `lasttimestamp' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flv/stream.rb:274:in `duration' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2/base.rb:181:in `add_meta_data_tag' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2/base.rb:137:in `update' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2/base.rb:47:in `send' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2/base.rb:47:in `execute!' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2/base.rb:46:in `each' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2/base.rb:46:in `execute!' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2/base.rb:239:in `process_files' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2/base.rb:225:in `each' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2/base.rb:225:in `process_files' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2/base.rb:44:in `execute!' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2.rb:168:in `execute!' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/lib/flvtool2.rb:228 ERROR: /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `gem_original_require' ERROR: /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `require' ERROR: /var/lib/gems/1.8/gems/flvtool2-1.0.6/bin/flvtool2:2 ERROR: /var/lib/gems/1.8/bin/flvtool2:18:in `load' ERROR: /var/lib/gems/1.8/bin/flvtool2:18" + @metadata_result = "--- /Users/jon/code/spinoza/rvideo/temp.flv: hasKeyframes: true spec/units/flvtool2_spec.rb @@ -18,6 +18,50 @@ module RVideo end end + describe Inspector, " when grabbing a frame" do + before do + @file = Inspector.new(:raw_response => files(:kites)) + end + + it "should calculate a timecode, when given a percentage" do + @file.duration.should == 19600 + @file.calculate_time("10%").should be_close(1.96, 0.1) + @file.calculate_time("1%").should be_close(0.196, 0.001) + @file.calculate_time("75%").should be_close(14.7, 0.1) + @file.calculate_time("100%").should be_close(19.6, 0.1) + end + + it "should calculate a timecode, when given a frame" do + @file.fps.should == "10.00" + @file.calculate_time("10f").should be_close(1.0, 0.1) + @file.calculate_time("27.6f").should be_close(2.76, 0.1) + + @file.stub!(:fps).and_return(29.97) + @file.calculate_time("276f").should be_close(9.2, 0.1) + @file.calculate_time("10f").should be_close(0.3, 0.1) + @file.calculate_time("29.97f").should be_close(1.0, 0.01) + end + + it "should return itself when given seconds" do + [1, 10, 14, 3.7, 2.8273, 16].each do |t| + @file.calculate_time("#{t}s").should == t + end + end + + it "should return itself when given no letter" do + [1, 10, 14, 3.7, 2.8273, 16].each do |t| + @file.calculate_time("#{t}").should == t + end + end + + it "should return a frame at 99%, when given something outside of the bounds of the file" do + nn = @file.calculate_time("99%") + %w(101% 20s 99 300f).each do |tc| + @file.calculate_time(tc).should be_close(nn, 0.01) + end + end + end + describe Inspector, " parsing ffmpeg info" do it "should read ffmpeg build data successfully (with a darwinports build)" do spec/units/inspector_spec.rb @@ -16,10 +16,11 @@ module RVideo @mencoder.tool_command.should == 'mencoder' end - it "should call parse_result on execute, with a mencoder result string" do - @mencoder.should_receive(:parse_result).once.with /\AMEncoder/ - @mencoder.execute - end + # FIXME see setup_mencoder_spec + # it "should call parse_result on execute, with a mencoder result string" do + # @mencoder.should_receive(:parse_result).once.with /\AMEncoder/ + # @mencoder.execute + # end it "should mixin AbstractTool" do Mencoder.included_modules.include?(AbstractTool::InstanceMethods).should be_true @@ -68,7 +69,14 @@ module RVideo end def setup_mencoder_spec - @options = {:input_file => "foo", :output_file => "bar", :resolution => "baz"} + @options = { + :input_file => spec_video("kites.mp4"), + :output_file => "bar", + :resolution => "copy" + } + + # FIXME these are not valid mencoder options + # maybe we just want to mock here anyway, but either way.. broken for now @simple_avi = "mencoder -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -s $resolution$ -y $output_file$" @mencoder = RVideo::Tools::Mencoder.new(@simple_avi, @options) spec/units/mencoder_spec.rb @@ -1,9 +1,10 @@ require File.dirname(__FILE__) + '/../spec_helper' def setup_spec - @options = {:input_file => "foo", :output_file => "bar", :resolution => "baz"} + @options = {:output_file => "bar", :resolution => "baz"} + @input_file = spec_video "kites.mp4" @simple_avi = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -s $resolution$ -y $output_file$" - @transcoder = RVideo::Transcoder.new + @transcoder = RVideo::Transcoder.new(@input_file) @mock_original_file = mock(:original) @mock_original_file.stub!(:raw_response) RVideo::Inspector.stub!(:new).and_return(@mock_original_file) @@ -11,7 +12,7 @@ end module RVideo - describe Transcoder, " when the execute method receives valid parameters" do + describe Transcoder, " execution" do before do setup_spec @transcoder.stub!(:check_integrity).and_return(true) @@ -27,11 +28,34 @@ module RVideo @mock_ffmpeg = mock("ffmpeg") Tools::AbstractTool.stub!(:assign).and_return(@mock_ffmpeg) @mock_ffmpeg.should_receive(:execute) + @mock_ffmpeg.stub!(:original=) @transcoder.execute(@simple_avi, @options) @transcoder.executed_commands.size.should == 1 @transcoder.executed_commands.first.should == @mock_ffmpeg end + it "should set original file" do + @mock_ffmpeg = mock("ffmpeg") + Tools::AbstractTool.stub!(:assign).and_return(@mock_ffmpeg) + @mock_ffmpeg.stub!(:execute) + @mock_ffmpeg.should_receive(:original=).with(@transcoder.original) + @transcoder.execute(@simple_avi, @options) + end + + # FIXME + # it "should raise an exception when trying to call a tool that doesn't exist" do + # lambda { + # @transcoder.send(:parse_and_execute, "foo -i bar", {}) + # }.should raise_error(TranscoderError::UnknownTool, /recipe tried to use the 'foo' tool/) + # end + + it "should raise an exception when the first argument is not a string" do + [String, 1, 1.0, true, nil, :foo].each do |obj| + lambda { + @transcoder.execute(obj, @options) + }.should raise_error(TranscoderError::ParameterError, /expected.*recipe.*string/i) + end + end end describe Transcoder, " file integrity checks" do @@ -41,14 +65,15 @@ module RVideo @transcoder.stub!(:parse_and_execute) @mock_processed_file = mock("processed") @mock_original_file.stub!(:duration).and_return 10 + @mock_original_file.stub!(:invalid?).and_return false @mock_processed_file.stub!(:duration).and_return 10 @mock_processed_file.stub!(:invalid?).and_return false - Inspector.should_receive(:new).once.with(:file => "foo").and_return(@mock_original_file) + #Inspector.should_receive(:new).once.with(:file => "foo").and_return(@mock_original_file) Inspector.should_receive(:new).once.with(:file => "bar").and_return(@mock_processed_file) end it "should call the inspector twice on a successful job, and should set @original and @processed" do - @transcoder.original.should be_nil + @transcoder.original.should_not be_nil @transcoder.processed.should be_nil @transcoder.execute(@simple_avi, @options) @@ -79,16 +104,15 @@ module RVideo describe Transcoder, "#parse_and_execute" do before do - @options = {:input_file => "foo", :output_file => "bar", :resolution => "baz"} - @simple_avi = "ffmpeg -i $input_file$ -ar 44100 -ab 64 -vcodec xvid -acodec mp3 -r 29.97 -s $resolution$ -y $output_file$" + setup_spec @mock_tool = mock("tool") @mock_tool.stub!(:execute) - @transcoder = Transcoder.new - Inspector.stub!(:new) + @mock_tool.stub!(:original=) + @options_plus_input = @options.merge(:input_file => @input_file) end it "should assign a command via AbstractTool.assign, and pass the right options" do - Tools::AbstractTool.should_receive(:assign).with(@simple_avi, @options).and_return(@mock_tool) + Tools::AbstractTool.should_receive(:assign).with(@simple_avi, @options_plus_input).and_return(@mock_tool) @transcoder.send(:parse_and_execute, @simple_avi, @options) end @@ -118,23 +142,4 @@ module RVideo end end - describe Transcoder, " when the execute method receives invalid parameters" do - before do - setup_spec - end - - it "should raise an exception when trying to call a tool that doesn't exist" do - lambda { - @transcoder.send(:parse_and_execute, "foo -i bar") - }.should raise_error(NameError, "uninitialized constant RVideo::Tools::Foo") - end - - it "should raise an exception when the first argument is not a string" do - [String, 1, 1.0, true, nil, :foo].each do |obj| - lambda { - @transcoder.execute(obj) - }.should raise_error(TranscoderError::UnknownError, /ArgumentError.*first/) - end - end - end end spec/units/transcoder_spec.rb spec/integrations/files/files.yml 7481a5632ec7da57b91331f12e5a7805bf0ab209 Seth Thomas Rasmussen sethrasmussen@gmail.com http://github.com/greatseth/rvideo/commit/42ffe6236c9d88b859fcf747327f180d5c6e67cf 42ffe6236c9d88b859fcf747327f180d5c6e67cf 2009-02-12T18:46:16-08:00 2009-02-12T18:46:16-08:00 copied over 0.9.4 svn and got specs passing 31f313d7ce8dece53905e9c5b6d5131fd634619a Seth Thomas Rasmussen sethrasmussen@gmail.com