@@ -20,12 +20,12 @@ class ActiveRecord::Base #As i know, not all the backends sort primay_key columns options.update(:order => "#{table_name}.#{primary_key} ASC") - i=minimum(primary_key, options) + i=minimum(primary_key, options) or return # first the first object by id yield(o=find_one(i, {})) # as long as we keep finding objects, keep going while o - with_scope (:find => {:conditions => [ "#{table_name}.#{primary_key} > ?", i]} ) do + with_scope(:find => {:conditions => [ "#{table_name}.#{primary_key} > ?", i]} ) do if o=find_initial(options) i=o.send primary_key yield(o) lib/active_record_each.rb @@ -50,4 +50,10 @@ class ActiveRecordEachTest < Test::Unit::TestCase def test_map_method_with_conditions assert_equal ["Guillermo"], User.map(:conditions => "users.name LIKE 'G%'") {|u| u.name} end + + def test_empty_result_set_dont_throw_exception + assert_nothing_raised (ActiveRecord::RecordNotFound) do + User.each(:conditions => "id = -1") { |u| u.name } + end + end end test/active_record_each_test.rb 9da1777e67c33b776dbd8c2fbca2d23f6d2fb243 Guillermo Álvarez guillermo@cientifico.net http://github.com/guillermo/active_record_each/commit/2d0b6d8e9a56d661512468807c9e9273710d09b7 2d0b6d8e9a56d661512468807c9e9273710d09b7 2008-05-18T09:46:44-07:00 2008-05-18T09:46:44-07:00 * Empty result set don't throw exception 94bc2f959078f4fa420ba05b5097c717a3bd8197 Guillermo Álvarez guillermo@cientifico.net