@@ -29,7 +29,8 @@ $time_of_queries = 0, $nextID = null, $logging_transaction = false, - $logging_transaction_action = false; + $logging_transaction_action = false, + $fkeys = array(); function &connect($server = DB_SERVER, $username = DB_SERVER_USERNAME, $password = DB_SERVER_PASSWORD, $database = DB_DATABASE, $port = DB_SERVER_PORT, $type = DB_DATABASE_CLASS) { require('database/' . $type . '.php'); @@ -500,81 +501,76 @@ if ($this->db_class->use_foreign_keys == false) { $query_action = substr($this->sql_query, 0, strpos($this->sql_query, ' ')); + if ( ($query_action == 'delete') || ($query_action == 'update') ) { + if ( empty($this->db_class->fkeys) ) { + $Qfk = new self($this->db_class); + $Qfk->setQuery('select * from :table_fk_relationships'); + $Qfk->bindTable(':table_fk_relationships', TABLE_FK_RELATIONSHIPS); +// $Qfk->setCache('fk_relationships'); + $Qfk->execute(); + + while ( $Qfk->next() ) { + $this->db_class->fkeys[$Qfk->value('to_table')][] = array('from_table' => $Qfk->value('from_table'), + 'from_field' => $Qfk->value('from_field'), + 'to_field' => $Qfk->value('to_field'), + 'on_update' => $Qfk->value('on_update'), + 'on_delete' => $Qfk->value('on_delete')); + } + + $Qfk->freeResult(); + } + } + if ($query_action == 'delete') { $query_data = split(' ', $this->sql_query, 4); $query_table = substr($query_data[2], strlen(DB_TABLE_PREFIX)); - $fk_check_query = $this->db_class->simpleQuery('select * from ' . TABLE_FK_RELATIONSHIPS . ' where to_table = "' . $query_table . '"'); - while ( $fk_check = $this->db_class->next($fk_check_query) ) { - $parent_query = $this->db_class->simpleQuery('select * from ' . $query_data[2] . ' ' . $query_data[3]); - while ( $parent_result = $this->db_class->next($parent_query) ) { - if ( $fk_check['on_delete'] == 'cascade' ) { - $Qdel = new self($this->db_class); - $Qdel->setQuery('delete from :from_table where :from_field = :' . $fk_check['from_field']); - $Qdel->bindTable(':from_table', DB_TABLE_PREFIX . $fk_check['from_table']); - $Qdel->bindRaw(':from_field', $fk_check['from_field'], false); - $Qdel->bindValue(':' . $fk_check['from_field'], $parent_result[$fk_check['to_field']]); - - if ( $this->logging === true ) { - if ( $this->db_class->logging_transaction === false ) { - $this->db_class->logging_transaction = true; - } + if ( isset($this->db_class->fkeys[$query_table]) ) { +// check for RESTRICT constraints first + foreach ( $this->db_class->fkeys[$query_table] as $fk ) { + if ( $fk['on_delete'] == 'restrict' ) { + $child_query = $this->db_class->simpleQuery('select ' . $fk['to_field'] . ' from ' . $query_data[2] . ' ' . $query_data[3]); + while ( $child_result = $this->db_class->next($child_query) ) { + $Qcheck = new self($this->db_class); + $Qcheck->setQuery('select ' . $fk['from_field'] . ' from ' . DB_TABLE_PREFIX . $fk['from_table'] . ' where ' . $fk['from_field'] . ' = "' . $child_result[$fk['to_field']] . '" limit 1'); + $Qcheck->execute(); - $Qdel->setLogging($this->logging_module, $this->logging_module_id); - } + if ( $Qcheck->numberOfRows() === 1 ) { + $this->db_class->setError('RESTRICT constraint condition from table ' . DB_TABLE_PREFIX . $fk['from_table'], null, $this->sql_query); - $Qdel->execute(); - } elseif ( $fk_check['on_delete'] == 'set_null' ) { - $Qupdate = new self($this->db_class); - $Qupdate->setQuery('update :from_table set :from_field = :' . $fk_check['from_field'] . ' where :from_field = :' . $fk_check['from_field']); - $Qupdate->bindTable(':from_table', DB_TABLE_PREFIX . $fk_check['from_table']); - $Qupdate->bindRaw(':from_field', $fk_check['from_field'], false); - $Qupdate->bindRaw(':' . $fk_check['from_field'], 'null'); - $Qupdate->bindRaw(':from_field', $fk_check['from_field'], false); - $Qupdate->bindValue(':' . $fk_check['from_field'], $parent_result[$fk_check['to_field']], false); - - if ( $this->logging === true ) { - if ( $this->db_class->logging_transaction === false ) { - $this->db_class->logging_transaction = true; + return false; } - - $Qupdate->setLogging($this->logging_module, $this->logging_module_id); } - - $Qupdate->execute(); } } - } - } elseif ($query_action == 'update') { - $query_data = split(' ', $this->sql_query, 3); - $query_table = substr($query_data[1], strlen(DB_TABLE_PREFIX)); - $fk_check_query = $this->db_class->simpleQuery('select * from ' . TABLE_FK_RELATIONSHIPS . ' where to_table = "' . $query_table . '"'); - while ( $fk_check = $this->db_class->next($fk_check_query) ) { -// check to see if foreign key column value is being changed - if ( strpos(substr($this->sql_query, strpos($this->sql_query, ' set ')+4, strpos($this->sql_query, ' where ') - strpos($this->sql_query, ' set ') - 4), ' ' . $fk_check['to_field'] . ' ') !== false ) { - $parent_query = $this->db_class->simpleQuery('select * from ' . $query_data[1] . substr($this->sql_query, strrpos($this->sql_query, ' where '))); + foreach ( $this->db_class->fkeys[$query_table] as $fk ) { + $parent_query = $this->db_class->simpleQuery('select * from ' . $query_data[2] . ' ' . $query_data[3]); while ( $parent_result = $this->db_class->next($parent_query) ) { - if ( ($fk_check['on_update'] == 'cascade') || ($fk_check['on_update'] == 'set_null') ) { - $on_update_value = ''; + if ( $fk['on_delete'] == 'cascade' ) { + $Qdel = new self($this->db_class); + $Qdel->setQuery('delete from :from_table where :from_field = :' . $fk['from_field']); + $Qdel->bindTable(':from_table', DB_TABLE_PREFIX . $fk['from_table']); + $Qdel->bindRaw(':from_field', $fk['from_field'], false); + $Qdel->bindValue(':' . $fk['from_field'], $parent_result[$fk['to_field']]); - if ( $fk_check['on_update'] == 'cascade' ) { - $on_update_value = $this->logging_fields[$fk_check['to_field']]; - } + if ( $this->logging === true ) { + if ( $this->db_class->logging_transaction === false ) { + $this->db_class->logging_transaction = true; + } - $Qupdate = new self($this->db_class); - $Qupdate->setQuery('update :from_table set :from_field = :' . $fk_check['from_field'] . ' where :from_field = :' . $fk_check['from_field']); - $Qupdate->bindTable(':from_table', DB_TABLE_PREFIX . $fk_check['from_table']); - $Qupdate->bindRaw(':from_field', $fk_check['from_field'], false); - - if ( empty($on_update_value) ) { - $Qupdate->bindRaw(':' . $fk_check['from_field'], 'null'); - } else { - $Qupdate->bindValue(':' . $fk_check['from_field'], $on_update_value); + $Qdel->setLogging($this->logging_module, $this->logging_module_id); } - $Qupdate->bindRaw(':from_field', $fk_check['from_field'], false); - $Qupdate->bindValue(':' . $fk_check['from_field'], $parent_result[$fk_check['to_field']], false); + $Qdel->execute(); + } elseif ( $fk['on_delete'] == 'set_null' ) { + $Qupdate = new self($this->db_class); + $Qupdate->setQuery('update :from_table set :from_field = :' . $fk['from_field'] . ' where :from_field = :' . $fk['from_field']); + $Qupdate->bindTable(':from_table', DB_TABLE_PREFIX . $fk['from_table']); + $Qupdate->bindRaw(':from_field', $fk['from_field'], false); + $Qupdate->bindRaw(':' . $fk['from_field'], 'null'); + $Qupdate->bindRaw(':from_field', $fk['from_field'], false); + $Qupdate->bindValue(':' . $fk['from_field'], $parent_result[$fk['to_field']], false); if ( $this->logging === true ) { if ( $this->db_class->logging_transaction === false ) { @@ -589,6 +585,69 @@ } } } + } elseif ($query_action == 'update') { + $query_data = split(' ', $this->sql_query, 3); + $query_table = substr($query_data[1], strlen(DB_TABLE_PREFIX)); + + if ( isset($this->db_class->fkeys[$query_table]) ) { +// check for RESTRICT constraints first + foreach ( $this->db_class->fkeys[$query_table] as $fk ) { + if ( $fk['on_update'] == 'restrict' ) { + $child_query = $this->db_class->simpleQuery('select ' . $fk['to_field'] . ' from ' . $query_data[2] . ' ' . $query_data[3]); + while ( $child_result = $this->db_class->next($child_query) ) { + $Qcheck = new self($this->db_class); + $Qcheck->setQuery('select ' . $fk['from_field'] . ' from ' . DB_TABLE_PREFIX . $fk['from_table'] . ' where ' . $fk['from_field'] . ' = "' . $child_result[$fk['to_field']] . '" limit 1'); + $Qcheck->execute(); + + if ( $Qcheck->numberOfRows() === 1 ) { + $this->db_class->setError('RESTRICT constraint condition from table ' . DB_TABLE_PREFIX . $fk['from_table'], null, $this->sql_query); + + return false; + } + } + } + } + + foreach ( $this->db_class->fkeys[$query_table] as $fk ) { +// check to see if foreign key column value is being changed + if ( strpos(substr($this->sql_query, strpos($this->sql_query, ' set ')+4, strpos($this->sql_query, ' where ') - strpos($this->sql_query, ' set ') - 4), ' ' . $fk['to_field'] . ' ') !== false ) { + $parent_query = $this->db_class->simpleQuery('select * from ' . $query_data[1] . substr($this->sql_query, strrpos($this->sql_query, ' where '))); + while ( $parent_result = $this->db_class->next($parent_query) ) { + if ( ($fk['on_update'] == 'cascade') || ($fk['on_update'] == 'set_null') ) { + $on_update_value = ''; + + if ( $fk['on_update'] == 'cascade' ) { + $on_update_value = $this->logging_fields[$fk['to_field']]; + } + + $Qupdate = new self($this->db_class); + $Qupdate->setQuery('update :from_table set :from_field = :' . $fk['from_field'] . ' where :from_field = :' . $fk['from_field']); + $Qupdate->bindTable(':from_table', DB_TABLE_PREFIX . $fk['from_table']); + $Qupdate->bindRaw(':from_field', $fk['from_field'], false); + + if ( empty($on_update_value) ) { + $Qupdate->bindRaw(':' . $fk['from_field'], 'null'); + } else { + $Qupdate->bindValue(':' . $fk['from_field'], $on_update_value); + } + + $Qupdate->bindRaw(':from_field', $fk['from_field'], false); + $Qupdate->bindValue(':' . $fk['from_field'], $parent_result[$fk['to_field']], false); + + if ( $this->logging === true ) { + if ( $this->db_class->logging_transaction === false ) { + $this->db_class->logging_transaction = true; + } + + $Qupdate->setLogging($this->logging_module, $this->logging_module_id); + } + + $Qupdate->execute(); + } + } + } + } + } } } includes/classes/database.php @@ -5986,26 +5986,26 @@ INSERT INTO osc_fk_relationships VALUES (null, 'categories_description', 'catego INSERT INTO osc_fk_relationships VALUES (null, 'categories_description', 'languages', 'language_id', 'languages_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'configuration', 'configuration_group', 'configuration_group_id', 'configuration_group_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'customers', 'address_book', 'customers_default_address_id', 'address_book_id', 'cascade', 'set_null'); -#INSERT INTO osc_fk_relationships VALUES (null, 'languages', 'currencies', 'currencies_id', 'currencies_id', 'cascade', 'restrict'); +INSERT INTO osc_fk_relationships VALUES (null, 'languages', 'currencies', 'currencies_id', 'currencies_id', 'cascade', 'restrict'); INSERT INTO osc_fk_relationships VALUES (null, 'languages_definitions', 'languages', 'languages_id', 'languages_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'manufacturers_info', 'manufacturers', 'manufacturers_id', 'manufacturers_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'manufacturers_info', 'languages', 'languages_id', 'languages_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'newsletters_log', 'newsletters', 'newsletters_id', 'newsletters_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'orders', 'customers', 'customers_id', 'customers_id', 'cascade', 'set_null'); -#INSERT INTO osc_fk_relationships VALUES (null, 'orders', 'orders_status', 'orders_status', 'orders_status_id', 'cascade', 'restrict'); +INSERT INTO osc_fk_relationships VALUES (null, 'orders', 'orders_status', 'orders_status', 'orders_status_id', 'cascade', 'restrict'); INSERT INTO osc_fk_relationships VALUES (null, 'orders_products', 'orders', 'orders_id', 'orders_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'orders_products_download', 'orders', 'orders_id', 'orders_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'orders_products_variants', 'orders', 'orders_id', 'orders_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'orders_status', 'languages', 'language_id', 'languages_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'orders_status_history', 'orders', 'orders_id', 'orders_id', 'cascade', 'cascade'); -#INSERT INTO osc_fk_relationships VALUES (null, 'orders_status_history', 'orders_status', 'orders_status_id', 'orders_status_id', 'cascade', 'restrict'); +INSERT INTO osc_fk_relationships VALUES (null, 'orders_status_history', 'orders_status', 'orders_status_id', 'orders_status_id', 'cascade', 'restrict'); INSERT INTO osc_fk_relationships VALUES (null, 'orders_total', 'orders', 'orders_id', 'orders_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'orders_transactions_history', 'orders', 'orders_id', 'orders_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'orders_transactions_status', 'languages', 'language_id', 'languages_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'product_attributes', 'products', 'products_id', 'products_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'product_attributes', 'languages', 'languages_id', 'languages_id', 'cascade', 'cascade'); INSERT INTO osc_fk_relationships VALUES (null, 'products', 'products', 'parent_id', 'products_id', 'cascade', 'cascade'); -#INSERT INTO osc_fk_relationships VALUES (null, 'products', 'weight_classes', 'products_weight_class', 'weight_class_id', 'cascade', 'restrict'); +INSERT INTO osc_fk_relationships VALUES (null, 'products', 'weight_classes', 'products_weight_class', 'weight_class_id', 'cascade', 'restrict'); INSERT INTO osc_fk_relationships VALUES (null, 'products', 'tax_class', 'products_tax_class_id', 'tax_class_id', 'cascade', 'set_null'); INSERT INTO osc_fk_relationships VALUES (null, 'products', 'manufacturers', 'manufacturers_id', 'manufacturers_id', 'cascade', 'set_null'); INSERT INTO osc_fk_relationships VALUES (null, 'products_description', 'products', 'products_id', 'products_id', 'cascade', 'cascade'); install/oscommerce.sql 7c37dfd984dead1abc9b0673341ce7fe5ea4b7b6 Harald Ponce de Leon hpdl@oscommerce.com http://github.com/haraldpdl/oscommerce/commit/57308c5e88eae1e278cdef471397e20129e5ae66 57308c5e88eae1e278cdef471397e20129e5ae66 2009-06-18T02:10:08-07:00 2009-06-18T02:10:08-07:00 Support RESTRICT foreign key constraints in the database class (for MyISAM databases) 65f58710726c222ae3657ddf18257fb4bfd0afe3 Harald Ponce de Leon hpdl@oscommerce.com